Move some v8 objects from CJS back into FXJS

Move some v8 objects from CJS back into FXJS

Create a new class to hold these, CFXJS_Engine (could have been
called Runtime, but there are too many "Runtimes" already). In a
subsequent patch, all the FXJS_*() functions that take an isolate
as the first argument can become methods on the engine.

CJS_ must still manage the isolates; this happens outside
the engine.

The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it
remains to allow for either a real JS library or a stubb one to
be linked (for non-js builds).

Committed: https://pdfium.googlesource.com/pdfium/+/a4941914bb4411dc4e9053cb344e0349db388007

[Tom Sepez, 2016-08-12 16:39:11]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-08-12 16:39:12]

Dan, for review.  Thanks.

[Tom Sepez, 2016-08-12 16:39:25]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 16:44:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 16:44:44]

Dry run: Try jobs failed on following builders:
  linux on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/1650)
  mac_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa/builds/...)

[Tom Sepez, 2016-08-12 16:44:51]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:44:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-12 16:45:38]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:45:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 17:13:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 17:13:29]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-12 17:25:58]

Description was changed from

==========
Move some v8 objects from CJS back into FXJS

Create a new class to hold these, CFXJS_Engine (could have been
called Runtime, but there are too many "Runtimes" already). In a
subsequent patch, all the FXJS_*() functions that take an isolate
as the first argument can become methods on the engine.

The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it
remains to allow for either a real JS library or a stubb one to
be linked (for non-js builds).
==========

to

==========
Move some v8 objects from CJS back into FXJS

Create a new class to hold these, CFXJS_Engine (could have been
called Runtime, but there are too many "Runtimes" already). In a
subsequent patch, all the FXJS_*() functions that take an isolate
as the first argument can become methods on the engine.

The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it
remains to allow for either a real JS library or a stubb one to
be linked (for non-js builds).
==========

[Tom Sepez, 2016-08-12 17:25:58]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[dsinclair, 2016-08-15 13:13:32]

https://codereview.chromium.org/2241483004/diff/20001/fxjs/include/fxjs_v8.h
File fxjs/include/fxjs_v8.h (right):

https://codereview.chromium.org/2241483004/diff/20001/fxjs/include/fxjs_v8.h#...
fxjs/include/fxjs_v8.h:21: 
#include <map>

https://codereview.chromium.org/2241483004/diff/20001/fxjs/include/fxjs_v8.h#...
fxjs/include/fxjs_v8.h:134: class CFXJS_Engine {
Any reason to not put this in it's own file?

[Tom Sepez, 2016-08-15 16:37:55]

https://codereview.chromium.org/2241483004/diff/20001/fxjs/include/fxjs_v8.h
File fxjs/include/fxjs_v8.h (right):

https://codereview.chromium.org/2241483004/diff/20001/fxjs/include/fxjs_v8.h#...
fxjs/include/fxjs_v8.h:21: 
On 2016/08/15 13:13:32, dsinclair wrote:
> #include <map>

Done.

https://codereview.chromium.org/2241483004/diff/20001/fxjs/include/fxjs_v8.h#...
fxjs/include/fxjs_v8.h:134: class CFXJS_Engine {
On 2016/08/15 13:13:32, dsinclair wrote:
> Any reason to not put this in it's own file?

There's a follow-on CL that puts most of this file into the 'engine.  We can
think about this after that lands.

[Tom Sepez, 2016-08-15 17:14:44]

Description was changed from

==========
Move some v8 objects from CJS back into FXJS

Create a new class to hold these, CFXJS_Engine (could have been
called Runtime, but there are too many "Runtimes" already). In a
subsequent patch, all the FXJS_*() functions that take an isolate
as the first argument can become methods on the engine.

The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it
remains to allow for either a real JS library or a stubb one to
be linked (for non-js builds).
==========

to

==========
Move some v8 objects from CJS back into FXJS

Create a new class to hold these, CFXJS_Engine (could have been
called Runtime, but there are too many "Runtimes" already). In a
subsequent patch, all the FXJS_*() functions that take an isolate
as the first argument can become methods on the engine.

CJS_ must still manage the isolates; this happens outside
the engine so that many engines might be created against
the same isolate, if desired.

The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it
remains to allow for either a real JS library or a stubb one to
be linked (for non-js builds).
==========

[Tom Sepez, 2016-08-15 17:16:25]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 17:16:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-08-15 17:22:18]

lgtm

[Tom Sepez, 2016-08-15 17:44:32]

Description was changed from

==========
Move some v8 objects from CJS back into FXJS

Create a new class to hold these, CFXJS_Engine (could have been
called Runtime, but there are too many "Runtimes" already). In a
subsequent patch, all the FXJS_*() functions that take an isolate
as the first argument can become methods on the engine.

CJS_ must still manage the isolates; this happens outside
the engine so that many engines might be created against
the same isolate, if desired.

The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it
remains to allow for either a real JS library or a stubb one to
be linked (for non-js builds).
==========

to

==========
Move some v8 objects from CJS back into FXJS

Create a new class to hold these, CFXJS_Engine (could have been
called Runtime, but there are too many "Runtimes" already). In a
subsequent patch, all the FXJS_*() functions that take an isolate
as the first argument can become methods on the engine.

CJS_ must still manage the isolates; this happens outside
the engine.

The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it
remains to allow for either a real JS library or a stubb one to
be linked (for non-js builds).
==========

[Tom Sepez, 2016-08-15 18:00:21]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 18:00:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-15 18:00:47]

On 2016/08/15 17:22:18, dsinclair wrote:
> lgtm

Dan, quick recheck vs. PS 3 due to tinkering.

[dsinclair, 2016-08-15 18:06:43]

lgtm

[Tom Sepez, 2016-08-15 18:28:23]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2016-08-15 18:28:30]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-08-15 18:28:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-15 18:28:41]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2016-08-15 18:28:47]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-08-15 18:28:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 18:40:14]

Description was changed from

==========
Move some v8 objects from CJS back into FXJS

Create a new class to hold these, CFXJS_Engine (could have been
called Runtime, but there are too many "Runtimes" already). In a
subsequent patch, all the FXJS_*() functions that take an isolate
as the first argument can become methods on the engine.

CJS_ must still manage the isolates; this happens outside
the engine.

The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it
remains to allow for either a real JS library or a stubb one to
be linked (for non-js builds).
==========

to

==========
Move some v8 objects from CJS back into FXJS

Create a new class to hold these, CFXJS_Engine (could have been
called Runtime, but there are too many "Runtimes" already). In a
subsequent patch, all the FXJS_*() functions that take an isolate
as the first argument can become methods on the engine.

CJS_ must still manage the isolates; this happens outside
the engine.

The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it
remains to allow for either a real JS library or a stubb one to
be linked (for non-js builds).

Committed:
https://pdfium.googlesource.com/pdfium/+/a4941914bb4411dc4e9053cb344e0349db38...
==========

[commit-bot: I haz the power, 2016-08-15 18:40:15]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/a4941914bb4411dc4e9053cb344e0349db38...