Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2241483003: Revert of Exact Ganesh Gradients for Special Cases (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
Reviewers:
bsalomon, fmenozzi
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Exact Ganesh Gradients for Special Cases (patchset #8 id:140001 of https://codereview.chromium.org/2223203003/ ) Reason for revert: Chrome iOS build break https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/50777/steps/compile/logs/stdio error: unused function 'close_to_one_half' Original issue's description: > Remove generalized gradient code > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223203003 > > Committed: https://skia.googlesource.com/skia/+/0c63006b88a16e3418d92852a62771615799839d > Committed: https://skia.googlesource.com/skia/+/99818d69372d29a139935cfe5c379e491432931b TBR=bsalomon@google.com,fmenozzi@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/cf736d7b66d76917c3384c0ad2f4cdc6d52db2a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -507 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 5 chunks +215 lines, -430 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 11 chunks +38 lines, -75 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hal.canary
Created Revert of Exact Ganesh Gradients for Special Cases
4 years, 4 months ago (2016-08-12 01:07:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241483003/1
4 years, 4 months ago (2016-08-12 01:07:32 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 01:07:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cf736d7b66d76917c3384c0ad2f4cdc6d52db2a1

Powered by Google App Engine
This is Rietveld 408576698