Chromium Code Reviews| Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc |
| diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc |
| index f77fcd4229788a661994fbd9fea079fd9098298d..1f41c85c7cf968356a8ddd56f40e9c0bac61e4c2 100644 |
| --- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc |
| +++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc |
| @@ -150,13 +150,14 @@ void BookmarkSuggestionsProvider::OnWillChangeBookmarkMetaInfo( |
| BookmarkModel* model, |
| const BookmarkNode* node) { |
| // Store the last visit date of the node that is about to change. |
| - node_to_change_last_visit_date_ = GetLastVisitDateForBookmark(node); |
| + node_to_change_last_visit_date_ = |
| + GetLastVisitDateForNotDismissedBookmark(node); |
| } |
| void BookmarkSuggestionsProvider::BookmarkMetaInfoChanged( |
| BookmarkModel* model, |
| const BookmarkNode* node) { |
| - base::Time time = GetLastVisitDateForBookmark(node); |
| + base::Time time = GetLastVisitDateForNotDismissedBookmark(node); |
| if (time == node_to_change_last_visit_date_ || |
| time < end_of_list_last_visit_date_) |
| return; |
| @@ -166,6 +167,20 @@ void BookmarkSuggestionsProvider::BookmarkMetaInfoChanged( |
| FetchBookmarks(); |
| } |
| +void BookmarkSuggestionsProvider::BookmarkNodeRemoved( |
| + bookmarks::BookmarkModel* model, |
| + const bookmarks::BookmarkNode* parent, |
| + int old_index, |
| + const bookmarks::BookmarkNode* node, |
| + const std::set<GURL>& no_longer_bookmarked) { |
| + if (GetLastVisitDateForNotDismissedBookmark(node) < |
| + end_of_list_last_visit_date_) |
| + return; |
| + |
| + // Some node from our list got deleted, we should update the suggestions. |
| + FetchBookmarks(); |
|
Marc Treib
2016/08/11 15:24:54
The bookmark might have been dismissed, but I gues
jkrcal
2016/08/11 15:41:35
The node it still valid at this point. Thus, GetLa
|
| +} |
| + |
| ContentSuggestion BookmarkSuggestionsProvider::ConvertBookmark( |
| const BookmarkNode* bookmark) { |
| ContentSuggestion suggestion( |