components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h - Issue 2241463002: Update bookmark suggestions also after undismiss/delete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

Issue 2241463002: Update bookmark suggestions also after undismiss/delete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc » ('j') | components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

diff --git a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

index 36ff7db1177532b10786341900df29872ae984fa..41f367baf10e5d893d6d9dbe6cfb0d387e9bac01 100644

--- a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

+++ b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

@@ -31,6 +31,11 @@ void UpdateBookmarkOnURLVisitedInMainFrame(

// this info, it returns it creation date.

base::Time GetLastVisitDateForBookmark(const bookmarks::BookmarkNode* node);

+// Like GetLastVisitDateForBookmark, but it returns the unix epoch if the

+// bookmark is dismissed from NTP.

+base::Time GetLastVisitDateForNotDismissedBookmark(

Marc Treib 2016/08/11 15:24:54 Hm, not super happy with this name, but I also can

jkrcal 2016/08/11 15:41:35 Better, thanks. Done.

+ const bookmarks::BookmarkNode* node);

// Marks all bookmarks with the given URL as dismissed.

void MarkBookmarksDismissed(bookmarks::BookmarkModel* bookmark_model,

const GURL& url);