Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 22414006: Revert "Revert "[css3-text] Implement text-decoration property shorthand"" (Closed)

Created:
7 years, 4 months ago by abinader
Modified:
7 years, 4 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, darktears, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, vcarbune.chromium, Savago-old
Visibility:
Public.

Description

Revert "Revert "[css3-text] Implement text-decoration property shorthand"" There was an assertion in StyleResolver caused by the lack of runtime features check in CSS shorthands style that prevented proper content_shell usage. This is now fixed in revision 155866: https://src.chromium.org/viewvc/blink?revision=155866&view=revision BUG=165462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155895

Patch Set 1 : #

Patch Set 2 : Added missing skipped test to TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -178 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/editing/deleting/delete-line-break-before-underlined-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/deleting-line-break-preserves-underline-color-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/merge-div-from-span-with-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/merge-paragraph-from-span-with-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/inline-style-after-indentoutdent-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/remove-format-multiple-elements-mac-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/script-tests/inline-style-after-indentoutdent.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/script-tests/remove-format-multiple-elements-mac.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/script-tests/toggle-style-2.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/execCommand/script-tests/toggle-text-decorations.js View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/execCommand/toggle-style-2-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/execCommand/toggle-text-decorations-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/execCommand/use-css.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/use-css-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/insert-u-with-text-decoration-none-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/preserve-underline-color-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/style/inline-style-container-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/style/push-down-implicit-styles-around-list-mac-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/style/push-down-implicit-styles-around-list-win-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/style/push-down-implicit-styles-mac-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/style/push-down-inline-styles-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/editing/style/script-tests/inline-style-container.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list-mac.js View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list-win.js View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/style/script-tests/push-down-implicit-styles-mac.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/style/script-tests/push-down-inline-styles.js View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt View 1 chunk +39 lines, -57 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js View 1 chunk +20 lines, -20 lines 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-1.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-3.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-3-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-4.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-4-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-5.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-5-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-disabled-attr.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-disabled-attr-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/style-enumerate-properties.html View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/fast/css/style-enumerate-properties-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
A LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand.html View 1 chunk +72 lines, -0 lines 0 comments Download
A LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand-expected.txt View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand-ordering.html View 1 chunk +69 lines, -0 lines 0 comments Download
A LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand-ordering-expected.txt View 1 chunk +39 lines, -0 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/w3c/test_media_queries.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-format-style-whitelist-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/styles/styles-computed-trace-expected.txt View 2 chunks +14 lines, -2 lines 0 comments Download
M LayoutTests/inspector/styles/styles-new-API-expected.txt View 3 chunks +9 lines, -0 lines 0 comments Download
M LayoutTests/media/track/track-css-matching-default.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/track/track-css-matching-default-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M Source/core/css/CSSShorthands.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 11 chunks +38 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abinader
What's changed from previous landed patch: - Added 'runtimeEnabledShorthand' value for text-decoration in CSSShorthands.in - ...
7 years, 4 months ago (2013-08-09 21:00:08 UTC) #1
abinader
On 2013/08/09 21:00:08, abinader wrote: > What's changed from previous landed patch: > > - ...
7 years, 4 months ago (2013-08-09 23:37:59 UTC) #2
Julien - ping for review
Assuming this change was tested in debug - *hum, hum* - lgtm. I would have ...
7 years, 4 months ago (2013-08-09 23:59:03 UTC) #3
abinader
On 2013/08/09 23:59:03, Julien Chaffraix wrote: > Assuming this change was tested in debug - ...
7 years, 4 months ago (2013-08-10 00:57:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruno.d@partner.samsung.com/22414006/9001
7 years, 4 months ago (2013-08-10 00:57:44 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 02:00:08 UTC) #6
Message was sent while issue was closed.
Change committed as 155895

Powered by Google App Engine
This is Rietveld 408576698