Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: LayoutTests/fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js

Issue 22414006: Revert "Revert "[css3-text] Implement text-decoration property shorthand"" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added missing skipped test to TestExpectations Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js
diff --git a/LayoutTests/fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js b/LayoutTests/fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js
index 0058a0ec5bfaa43e9b9fb1cbfdc7b06c2486dfb6..7635d28d40f04f1d4902e1e06d50f2f3e4cd6d3f 100644
--- a/LayoutTests/fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js
+++ b/LayoutTests/fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js
@@ -26,68 +26,68 @@ testContainer.innerHTML = '<div id="test">hello world</div>';
debug("Initial value:");
e = document.getElementById('test');
testElementStyle("textDecoration", "text-decoration", null, '');
-testComputedStyle("textDecoration", "text-decoration", "[object CSSPrimitiveValue]", "none");
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "none solid rgb(0, 0, 0)");
debug('');
debug("Initial value (explicit):");
e.style.textDecoration = 'initial';
-testElementStyle("textDecoration", "text-decoration", "[object CSSValue]", "initial");
-testComputedStyle("textDecoration", "text-decoration", "[object CSSPrimitiveValue]", "none");
+testElementStyle("textDecoration", "text-decoration", null, '');
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "none solid rgb(0, 0, 0)");
debug('');
debug("Value 'none':");
e.style.textDecoration = 'none';
-testElementStyle("textDecoration", "text-decoration", "[object CSSPrimitiveValue]", "none");
-testComputedStyle("textDecoration", "text-decoration", "[object CSSPrimitiveValue]", "none");
+testElementStyle("textDecoration", "text-decoration", null, '');
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "none solid rgb(0, 0, 0)");
debug('');
debug("Value 'underline':");
e.style.textDecoration = 'underline';
-testElementStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline");
-testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline");
+testElementStyle("textDecoration", "text-decoration", null, '');
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline solid rgb(0, 0, 0)");
debug('');
debug("Value 'overline':");
e.style.textDecoration = 'overline';
-testElementStyle("textDecoration", "text-decoration", "[object CSSValueList]", "overline");
-testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "overline");
+testElementStyle("textDecoration", "text-decoration", null, '');
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "overline solid rgb(0, 0, 0)");
debug('');
debug("Value 'line-through':");
e.style.textDecoration = 'line-through';
-testElementStyle("textDecoration", "text-decoration", "[object CSSValueList]", "line-through");
-testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "line-through");
+testElementStyle("textDecoration", "text-decoration", null, '');
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "line-through solid rgb(0, 0, 0)");
debug('');
debug("Value 'underline overline line-through':");
e.style.textDecoration = 'underline overline line-through';
-testElementStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline overline line-through");
-testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline overline line-through");
+testElementStyle("textDecoration", "text-decoration", null, '');
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline overline line-through solid rgb(0, 0, 0)");
debug('');
debug("Value 'blink' (valid but ignored):");
e.style.textDecoration = 'blink';
-testElementStyle("textDecoration", "text-decoration", "[object CSSValueList]", "blink");
-testComputedStyle("textDecoration", "text-decoration", "[object CSSPrimitiveValue]", "none");
+testElementStyle("textDecoration", "text-decoration", null, '');
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "none solid rgb(0, 0, 0)");
debug('');
debug("Value '':");
e.style.textDecoration = '';
testElementStyle("textDecoration", "text-decoration", null, '');
-testComputedStyle("textDecoration", "text-decoration", "[object CSSPrimitiveValue]", "none");
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "none solid rgb(0, 0, 0)");
debug('');
testContainer.innerHTML = '<div id="test-parent" style="text-decoration: underline;">hello <span id="test-ancestor" style="text-decoration: inherit;">world</span></div>';
debug("Parent gets 'underline' value:");
e = document.getElementById('test-parent');
-testElementStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline");
-testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline");
+testElementStyle("textDecoration", "text-decoration", null, '');
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline solid rgb(0, 0, 0)");
debug('');
debug("Ancestor should explicitly inherit value from parent when 'inherit' value is used:");
e = document.getElementById('test-ancestor');
-testElementStyle("textDecoration", "text-decoration", "[object CSSValue]", "inherit");
-testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline");
+testElementStyle("textDecoration", "text-decoration", null, '');
+testComputedStyle("textDecoration", "text-decoration", "[object CSSValueList]", "underline solid rgb(0, 0, 0)");
debug('');
debug("Ancestor should not implicitly inherit value from parent (i.e. when value is void):");

Powered by Google App Engine
This is Rietveld 408576698