Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2241383005: Disable heap shim for SyzyASAN builds. (Closed)

Created:
4 years, 4 months ago by Sigurður Ásgeirsson
Modified:
4 years, 4 months ago
Reviewers:
scottmg, Will Harris
CC:
chromium-reviews, syzygy-team_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable heap shim for SyzyASAN builds. This fixes the build failure on the Win SyzyASAN LKGR caused by https://codereview.chromium.org/2164653002/. BUG=550886 Committed: https://crrev.com/0fb851b955098e98cbd7d7c534a88b907ba9d157 Cr-Commit-Position: refs/heads/master@{#412294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/allocator.gni View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Sigurður Ásgeirsson
PTAL - Will for goodness, Scott for owners, pretty please? This should fix the SyzyASAN ...
4 years, 4 months ago (2016-08-16 17:19:51 UTC) #4
scottmg
lgtm Maybe we should have an is_sanitizer_build (or something)?
4 years, 4 months ago (2016-08-16 17:27:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241383005/1
4 years, 4 months ago (2016-08-16 18:10:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 18:14:31 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 18:17:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fb851b955098e98cbd7d7c534a88b907ba9d157
Cr-Commit-Position: refs/heads/master@{#412294}

Powered by Google App Engine
This is Rietveld 408576698