Heap shim, conditionally declare otherwise unused global on Windows.

Heap shim, conditionally declare otherwise unused global on Windows.

BUG=550886

[Will Harris, 2016-08-16 18:34:13]

wfh@chromium.org changed reviewers:
+ wfh@chromium.org

[Will Harris, 2016-08-16 18:34:13]

lgtm

[Sigurður Ásgeirsson, 2016-08-16 18:35:53]

siggi@chromium.org changed reviewers:
+ scottmg@chromium.org

[Sigurður Ásgeirsson, 2016-08-16 18:35:54]

This is an attempted fix for the Win ASAN LKGR builders. I'm not quite sure
what's going on here, as the shim shouldn't be enabled for NaCl. Presumably it's
getting compiled, but then not linked into the NaCl targets. Maybe I'm
misreading the command line?

https://build.chromium.org/p/chromium.lkgr/builders/Win%20ASan%20Release/buil...

[7659/31897] CXX
clang_nacl_win64/obj/base/allocator/unified_allocator_shim/allocator_shim.obj
FAILED:
clang_nacl_win64/obj/base/allocator/unified_allocator_shim/allocator_shim.obj 
C:\b\c\cipd\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@clang_nacl_win64/obj/base/allocator/unified_allocator_shim/allocator_shim.obj.rsp
/c ../../base/allocator/allocator_shim.cc
/Foclang_nacl_win64/obj/base/allocator/unified_allocator_shim/allocator_shim.obj
/Fd"clang_nacl_win64/obj/base/allocator/unified_allocator_shim_cc.pdb"
../../base/allocator/allocator_shim.cc(37,18):  error: unused variable
'g_new_handler_lock' [-Werror,-Wunused-variable]
subtle::Atomic32 g_new_handler_lock = 0;

[Sigurður Ásgeirsson, 2016-08-16 18:38:05]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 18:38:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 19:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 19:21:23]

Dry run: This issue passed the CQ dry run.

[Sigurður Ásgeirsson, 2016-08-16 20:45:52]

The CQ bit was checked by siggi@chromium.org

[commit-bot: I haz the power, 2016-08-16 20:46:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 20:52:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 20:52:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scottmg, 2016-08-16 20:53:42]

rs lgtm

[scottmg, 2016-08-16 20:53:47]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-08-16 20:54:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-08-16 20:54:30]

oh wait, was a patch failure not owners which wfh already is. ignore me, sorry.

[commit-bot: I haz the power, 2016-08-16 20:59:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 20:59:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sigurður Ásgeirsson, 2016-08-17 13:27:39]

The CQ bit was checked by siggi@chromium.org

[Sigurður Ásgeirsson, 2016-08-17 13:27:40]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org,
scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2250203002/#ps20001
(title: "Merge ToT.")

[commit-bot: I haz the power, 2016-08-17 13:27:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2016-08-17 13:28:14]

The CQ bit was unchecked by siggi@chromium.org

[Sigurður Ásgeirsson, 2016-08-17 13:30:14]

siggi@chromium.org changed reviewers:
+ hans@chromium.org

[Sigurður Ásgeirsson, 2016-08-17 13:30:15]

Looks like Hans beat me to the punch with
https://codereview.chromium.org/2246863004. Killing this CL - thanks Hans.