Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2241383002: Android: Attach hidden layer for CopyFromCompositingSurface() (Closed)

Created:
4 years, 4 months ago by no sievers
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Android: Attach hidden layer for CopyFromCompositingSurface() When the RenderWidgetHostView becomes invisible we might tear down the layer, which removes the impl layer from the impl layer, which will cause the Surface not to be added as a dependant Surface of the root Surface. Make sure readbacks actually complete (as long as the display is drawing) by attaching a hidden layer for the readback Surface. BUG=636628, 574537 TBR=dtrainor@chromium.org Review-Url: https://codereview.chromium.org/2243663002 Cr-Commit-Position: refs/heads/master@{#411502} (cherry picked from commit 02d8a97db2cf9fdca8042ce72416db6b5fc2abbc) Committed: https://chromium.googlesource.com/chromium/src/+/d6837f6960cc65cdf821f1985f68e01240187724

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M content/browser/renderer_host/compositor_impl_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 chunks +11 lines, -3 lines 0 comments Download
M ui/android/window_android_compositor.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
no sievers
4 years, 4 months ago (2016-08-15 18:48:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d6837f6960cc65cdf821f1985f68e01240187724 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698