Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2241373002: [Merge to 2785] Fix omnibox flickering on macOS Sierra. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge to 2785] Fix omnibox flickering on macOS Sierra. > The implementation of -[AutocompleteTextFieldEditor interpretKeyEvents:] > invalidates layout twice, in ways that are somehow not compatible on macOS > Sierra. This causes repaints on the next two frames, the first of which does > not paint the text correctly. Forcing an explicit relayout causes there to be > only a single repaint, with the correct contents. > > BUG=634318 > > Review-Url: https://codereview.chromium.org/2237003004 > Cr-Commit-Position: refs/heads/master@{#411495} > (cherry picked from commit c95767396148abe3e0b7d2ac07262a90dd76a6ae) Committed: https://chromium.googlesource.com/chromium/src/+/0c384764c4aaf6c453f0cf80fb2fdecc9124e472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
erikchen
4 years, 4 months ago (2016-08-15 18:26:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c384764c4aaf6c453f0cf80fb2fdecc9124e472.

Powered by Google App Engine
This is Rietveld 408576698