Fix omnibox flickering on macOS Sierra.

Fix omnibox flickering on macOS Sierra.

The implementation of -[AutocompleteTextFieldEditor interpretKeyEvents:]
invalidates layout twice, in ways that are somehow not compatible on macOS
Sierra. This causes repaints on the next two frames, the first of which does
not paint the text correctly. Forcing an explicit relayout causes there to be
only a single repaint, with the correct contents.

BUG=634318
Committed: https://crrev.com/c95767396148abe3e0b7d2ac07262a90dd76a6ae
Cr-Commit-Position: refs/heads/master@{#411495}

[erikchen, 2016-08-11 20:38:54]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 20:39:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-08-11 20:53:27]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2016-08-11 20:53:27]

mark: Please review.

[Mark Mentovai, 2016-08-11 21:24:45]

LGTM

Nice investigative work. Thanks very much for looking into this!

[erikchen, 2016-08-11 21:25:52]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2016-08-11 21:25:52]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-08-11 21:26:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 23:34:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 23:34:21]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-08-12 00:19:36]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-08-12 00:20:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 00:52:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 00:55:24]

Description was changed from

==========
Fix omnibox flickering on macOS Sierra.

The implementation of -[AutocompleteTextFieldEditor interpretKeyEvents:]
invalidates layout twice, in ways that are somehow not compatible on macOS
Sierra. This causes repaints on the next two frames, the first of which does
not paint the text correctly. Forcing an explicit relayout causes there to be
only a single repaint, with the correct contents.

BUG=634318
==========

to

==========
Fix omnibox flickering on macOS Sierra.

The implementation of -[AutocompleteTextFieldEditor interpretKeyEvents:]
invalidates layout twice, in ways that are somehow not compatible on macOS
Sierra. This causes repaints on the next two frames, the first of which does
not paint the text correctly. Forcing an explicit relayout causes there to be
only a single repaint, with the correct contents.

BUG=634318

Committed: https://crrev.com/c95767396148abe3e0b7d2ac07262a90dd76a6ae
Cr-Commit-Position: refs/heads/master@{#411495}
==========

[commit-bot: I haz the power, 2016-08-12 00:55:25]

Patchset 1 (id:??) landed as
https://crrev.com/c95767396148abe3e0b7d2ac07262a90dd76a6ae
Cr-Commit-Position: refs/heads/master@{#411495}