Remove parameter node from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar

Remove parameter node from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar

This patch removes parameter |node| from the above mentioned function because
it can always be computed as the root editable element of |insertedRange|.

This patch is a preparation for reducing the use of TextCheckingParagraph in
spell checker, since TextCheckingParagraph was introduced for synchronous
spell checking which no longer exists now.

BUG=619452
Committed: https://crrev.com/c4ce09744c75c1060c10bd1ac75455db27429e73
Cr-Commit-Position: refs/heads/master@{#412504}

[Xiaocheng, 2016-08-17 08:29:16]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 08:29:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-17 08:42:52]

Description was changed from

==========
Remove parameter node from
SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar

BUG=
==========

to

==========
Remove parameter node from
SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar

This patch removes parameter |node| from the above mentioned function because
it can always be computed as the root editable element of |insertedRange|.

This patch is a preparation for reducing the use of TextCheckingParagraph in
spell checker, since TextCheckingParagraph was introduced for synchronous
spell checking which no longer exists now.

BUG=619452
==========

[Xiaocheng, 2016-08-17 08:45:01]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-17 08:45:01]

PTAL.

I think at the end of a ReplaceSelectionCommand, |endingSelection()| and
|insertedRange()| always have the same root editable element (unless
|insertedRange()| is null), so there is no need to pass this element explicitly
to the spell checker. Am I right?

[yosin_UTC9, 2016-08-17 09:29:43]

On 2016/08/17 at 08:45:01, xiaochengh wrote:
> PTAL.
> 
> I think at the end of a ReplaceSelectionCommand, |endingSelection()| and
|insertedRange()| always have the same root editable element (unless
|insertedRange()| is null), so there is no need to pass this element explicitly
to the spell checker. Am I right?

lgtm

Yes, I agree with you.
Could you add DCHECK_EQ() to verify this assumption?

[Xiaocheng, 2016-08-17 09:44:01]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 09:44:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-17 09:47:03]

Thanks. DCHECK added.

I'll commit if nothing goes wrong.

[commit-bot: I haz the power, 2016-08-17 12:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 12:03:07]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-17 12:03:48]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-08-17 12:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2241293006/#ps20001
(title: "Add DCHECK")

[commit-bot: I haz the power, 2016-08-17 12:03:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 12:07:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 12:09:39]

Description was changed from

==========
Remove parameter node from
SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar

This patch removes parameter |node| from the above mentioned function because
it can always be computed as the root editable element of |insertedRange|.

This patch is a preparation for reducing the use of TextCheckingParagraph in
spell checker, since TextCheckingParagraph was introduced for synchronous
spell checking which no longer exists now.

BUG=619452
==========

to

==========
Remove parameter node from
SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar

This patch removes parameter |node| from the above mentioned function because
it can always be computed as the root editable element of |insertedRange|.

This patch is a preparation for reducing the use of TextCheckingParagraph in
spell checker, since TextCheckingParagraph was introduced for synchronous
spell checking which no longer exists now.

BUG=619452

Committed: https://crrev.com/c4ce09744c75c1060c10bd1ac75455db27429e73
Cr-Commit-Position: refs/heads/master@{#412504}
==========

[commit-bot: I haz the power, 2016-08-17 12:09:44]

Patchset 2 (id:??) landed as
https://crrev.com/c4ce09744c75c1060c10bd1ac75455db27429e73
Cr-Commit-Position: refs/heads/master@{#412504}