third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2241293006: Remove parameter node from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2241293006: Remove parameter node from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add DCHECK Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index 3dfce44193cb8660f513ecea7a95fa790169c084..91df8d4815b927adecc3f63cd6212657ff8bc16b 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -714,7 +714,9 @@ void Editor::requestSpellcheckingAfterApplyingCommand(CompositeEditCommand* cmd)

const EphemeralRange& insertedRange = toReplaceSelectionCommand(cmd)->insertedRange();

if (insertedRange.isNull())

return;

- spellChecker().chunkAndMarkAllMisspellingsAndBadGrammar(cmd->endingSelection().rootEditableElement(), insertedRange);

+ // Patch crrev.com/2241293006 assumes the following equality. Revert if it fails.

+ DCHECK_EQ(cmd->endingSelection().rootEditableElement(), rootEditableElementOf(insertedRange.startPosition()));

+ spellChecker().chunkAndMarkAllMisspellingsAndBadGrammar(insertedRange);

}

void Editor::appliedEditing(CompositeEditCommand* cmd)

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h » ('j') | no next file with comments »