Revert of Implement BluetoothGattNotifySession::Stop on Android

Revert of Implement BluetoothGattNotifySession::Stop on Android (patchset #33 id:640001 of https://codereview.chromium.org/2051333004/ )

Reason for revert:
Suspect of breaking https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/2450

[345/345] BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged (TIMED OUT)
6 tests timed out:
    BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1931)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1026)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_Multiple (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1067)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnIndicate (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1039)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnNotifyAndIndicate (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1054)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_Reentrant_Success_Success (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1217)

Original issue's description:
> Implement BluetoothGattNotifySession::Stop on Android
>
> This change enables the stopNotifications function for remote GATT
> characteristics on Android. In order to do so, two distinct refactorings have been done;
>
> 1) The session classes have been simplified so that platform specific versions are no longer required. All code that previously used BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base BluetoothGattNotifySession class.
>
> 2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession have been rewritten so that all the code for keeping track of the different session objects and the notification state sits in the base class. Inheriting classes should no longer override these two functions, but instead override the much simpler SubscribeToNotifications and UnsubscribeFromNotifications.
>
> BUG=584370
>
> Committed: https://crrev.com/d41af3adfd8500c81c827ab03ed2736909cf1ee8
> Cr-Commit-Position: refs/heads/master@{#412498}

TBR=ortuno@chromium.org,rkc@chromium.org,msarda@chromium.org,sacomoto@chromium.org,tommyt@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584370
Committed: https://crrev.com/ff985814a5a6df794c2be89fcbb3d789a8f31dc2
Cr-Commit-Position: refs/heads/master@{#412557}

[Guido Urdaneta, 2016-08-17 16:38:43]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-08-17 16:38:43]

Created Revert of Implement BluetoothGattNotifySession::Stop on Android

[commit-bot: I haz the power, 2016-08-17 16:39:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 16:40:15]

Description was changed from

==========
Revert of Implement BluetoothGattNotifySession::Stop on Android (patchset #33
id:640001 of https://codereview.chromium.org/2051333004/ )

Reason for revert:
Suspect of breaking
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/2450

[345/345] BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged
(TIMED OUT)
6 tests timed out:
    BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1931)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1026)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_Multiple
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1067)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnIndicate
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1039)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnNotifyAndIndicate
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1054)
   
BluetoothRemoteGattCharacteristicTest.StartNotifySession_Reentrant_Success_Success
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1217)

Original issue's description:
> Implement BluetoothGattNotifySession::Stop on Android
> 
> This change enables the stopNotifications function for remote GATT
> characteristics on Android. In order to do so, two distinct refactorings have
been done;
> 
> 1) The session classes have been simplified so that platform specific versions
are no longer required. All code that previously used
BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base
BluetoothGattNotifySession class.
> 
> 2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession
have been rewritten so that all the code for keeping track of the different
session objects and the notification state sits in the base class. Inheriting
classes should no longer override these two functions, but instead override the
much simpler SubscribeToNotifications and UnsubscribeFromNotifications.
> 
> BUG=584370
> 
> Committed: https://crrev.com/d41af3adfd8500c81c827ab03ed2736909cf1ee8
> Cr-Commit-Position: refs/heads/master@{#412498}

TBR=ortuno@chromium.org,rkc@chromium.org,msarda@chromium.org,sacomoto@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584370
==========

to

==========
Revert of Implement BluetoothGattNotifySession::Stop on Android (patchset #33
id:640001 of https://codereview.chromium.org/2051333004/ )

Reason for revert:
Suspect of breaking
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/2450

[345/345] BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged
(TIMED OUT)
6 tests timed out:
    BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1931)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1026)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_Multiple
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1067)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnIndicate
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1039)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnNotifyAndIndicate
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1054)
   
BluetoothRemoteGattCharacteristicTest.StartNotifySession_Reentrant_Success_Success
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1217)

Original issue's description:
> Implement BluetoothGattNotifySession::Stop on Android
> 
> This change enables the stopNotifications function for remote GATT
> characteristics on Android. In order to do so, two distinct refactorings have
been done;
> 
> 1) The session classes have been simplified so that platform specific versions
are no longer required. All code that previously used
BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base
BluetoothGattNotifySession class.
> 
> 2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession
have been rewritten so that all the code for keeping track of the different
session objects and the notification state sits in the base class. Inheriting
classes should no longer override these two functions, but instead override the
much simpler SubscribeToNotifications and UnsubscribeFromNotifications.
> 
> BUG=584370
> 
> Committed: https://crrev.com/d41af3adfd8500c81c827ab03ed2736909cf1ee8
> Cr-Commit-Position: refs/heads/master@{#412498}

TBR=ortuno@chromium.org,rkc@chromium.org,msarda@chromium.org,sacomoto@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584370
==========

[commit-bot: I haz the power, 2016-08-17 16:40:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-17 16:43:24]

Description was changed from

==========
Revert of Implement BluetoothGattNotifySession::Stop on Android (patchset #33
id:640001 of https://codereview.chromium.org/2051333004/ )

Reason for revert:
Suspect of breaking
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/2450

[345/345] BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged
(TIMED OUT)
6 tests timed out:
    BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1931)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1026)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_Multiple
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1067)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnIndicate
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1039)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnNotifyAndIndicate
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1054)
   
BluetoothRemoteGattCharacteristicTest.StartNotifySession_Reentrant_Success_Success
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1217)

Original issue's description:
> Implement BluetoothGattNotifySession::Stop on Android
> 
> This change enables the stopNotifications function for remote GATT
> characteristics on Android. In order to do so, two distinct refactorings have
been done;
> 
> 1) The session classes have been simplified so that platform specific versions
are no longer required. All code that previously used
BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base
BluetoothGattNotifySession class.
> 
> 2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession
have been rewritten so that all the code for keeping track of the different
session objects and the notification state sits in the base class. Inheriting
classes should no longer override these two functions, but instead override the
much simpler SubscribeToNotifications and UnsubscribeFromNotifications.
> 
> BUG=584370
> 
> Committed: https://crrev.com/d41af3adfd8500c81c827ab03ed2736909cf1ee8
> Cr-Commit-Position: refs/heads/master@{#412498}

TBR=ortuno@chromium.org,rkc@chromium.org,msarda@chromium.org,sacomoto@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584370
==========

to

==========
Revert of Implement BluetoothGattNotifySession::Stop on Android (patchset #33
id:640001 of https://codereview.chromium.org/2051333004/ )

Reason for revert:
Suspect of breaking
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/2450

[345/345] BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged
(TIMED OUT)
6 tests timed out:
    BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1931)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1026)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_Multiple
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1067)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnIndicate
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1039)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnNotifyAndIndicate
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1054)
   
BluetoothRemoteGattCharacteristicTest.StartNotifySession_Reentrant_Success_Success
(../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1217)

Original issue's description:
> Implement BluetoothGattNotifySession::Stop on Android
>
> This change enables the stopNotifications function for remote GATT
> characteristics on Android. In order to do so, two distinct refactorings have
been done;
>
> 1) The session classes have been simplified so that platform specific versions
are no longer required. All code that previously used
BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base
BluetoothGattNotifySession class.
>
> 2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession
have been rewritten so that all the code for keeping track of the different
session objects and the notification state sits in the base class. Inheriting
classes should no longer override these two functions, but instead override the
much simpler SubscribeToNotifications and UnsubscribeFromNotifications.
>
> BUG=584370
>
> Committed: https://crrev.com/d41af3adfd8500c81c827ab03ed2736909cf1ee8
> Cr-Commit-Position: refs/heads/master@{#412498}

TBR=ortuno@chromium.org,rkc@chromium.org,msarda@chromium.org,sacomoto@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584370

Committed: https://crrev.com/ff985814a5a6df794c2be89fcbb3d789a8f31dc2
Cr-Commit-Position: refs/heads/master@{#412557}
==========

[commit-bot: I haz the power, 2016-08-17 16:43:28]

Patchset 1 (id:??) landed as
https://crrev.com/ff985814a5a6df794c2be89fcbb3d789a8f31dc2
Cr-Commit-Position: refs/heads/master@{#412557}