build/android/gyp/lint.py - Issue 2241233002: Reland of Fail builds when lint warnings are generated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/lint.py

Issue 2241233002: Reland of Fail builds when lint warnings are generated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + add more suppressions Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/gyp/lint.py

diff --git a/build/android/gyp/lint.py b/build/android/gyp/lint.py

index a13a675341ad85f8c9aa783f773cdbd30802f9d0..643ca9d56f00cb9c3c082a47b0b7060dfb7dfb97 100755

--- a/build/android/gyp/lint.py

+++ b/build/android/gyp/lint.py

@@ -331,7 +331,10 @@ def main():

else:

input_paths.append(resource_source)

- input_strings = []

+ input_strings = [

+ args.can_fail_build,

+ args.silent,

+ ]

if args.android_sdk_version:

input_strings.append(args.android_sdk_version)

if args.processed_config_path:

« no previous file with comments | « no previous file | build/android/lint/suppressions.xml » ('j') | no next file with comments »