Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2241223002: Re-enable WebRTC audio quality tests in Windows (Closed)

Created:
4 years, 4 months ago by ehmaldonado_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable WebRTC audio quality tests in Windows and disables the test that is failing. The idea is to recover some of the coverage that the other tests provide. BUG=625808 Committed: https://crrev.com/4f9e4b86ce324df24410dc0b021dac1525172a71 Cr-Commit-Position: refs/heads/master@{#412507}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed MAYBE_... to MAYBE_MANUAL_... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/media/webrtc_audio_quality_browsertest.cc View 1 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ehmaldonado_chromium
https://codereview.chromium.org/2241223002/diff/1/chrome/browser/media/webrtc_audio_quality_browsertest.cc File chrome/browser/media/webrtc_audio_quality_browsertest.cc (right): https://codereview.chromium.org/2241223002/diff/1/chrome/browser/media/webrtc_audio_quality_browsertest.cc#newcode817 chrome/browser/media/webrtc_audio_quality_browsertest.cc:817: MAYBE_TestAutoGainIsOffWithAudioProcessingOff) { Is this OK, or should I write ...
4 years, 4 months ago (2016-08-15 13:42:00 UTC) #2
kjellander_chromium
lgtm with comment addressed. I'm not in OWNERS here though https://codereview.chromium.org/2241223002/diff/1/chrome/browser/media/webrtc_audio_quality_browsertest.cc File chrome/browser/media/webrtc_audio_quality_browsertest.cc (right): https://codereview.chromium.org/2241223002/diff/1/chrome/browser/media/webrtc_audio_quality_browsertest.cc#newcode817 ...
4 years, 4 months ago (2016-08-15 13:53:44 UTC) #3
ehmaldonado_chromium
4 years, 4 months ago (2016-08-15 14:17:14 UTC) #6
ehmaldonado_chromium
tommi, can you review please?
4 years, 4 months ago (2016-08-15 14:17:32 UTC) #7
tommi (sloooow) - chröme
lgtm
4 years, 4 months ago (2016-08-17 11:39:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241223002/20001
4 years, 4 months ago (2016-08-17 11:39:43 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 12:15:51 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 12:18:06 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f9e4b86ce324df24410dc0b021dac1525172a71
Cr-Commit-Position: refs/heads/master@{#412507}

Powered by Google App Engine
This is Rietveld 408576698