Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: chrome/browser/media/webrtc_audio_quality_browsertest.cc

Issue 2241223002: Re-enable WebRTC audio quality tests in Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed MAYBE_... to MAYBE_MANUAL_... Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <ctime> 7 #include <ctime>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_enumerator.h" 10 #include "base/files/file_enumerator.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 // segment is significantly different in length compared to the same segment in 54 // segment is significantly different in length compared to the same segment in
55 // the reference file, there's something fishy going on. 55 // the reference file, there's something fishy going on.
56 const int kMaxAgcSegmentDiffMs = 56 const int kMaxAgcSegmentDiffMs =
57 #if defined(OS_MACOSX) 57 #if defined(OS_MACOSX)
58 // Something is different on Mac; http://crbug.com/477653. 58 // Something is different on Mac; http://crbug.com/477653.
59 600; 59 600;
60 #else 60 #else
61 200; 61 200;
62 #endif 62 #endif
63 63
64 #if defined(OS_LINUX) || defined(OS_MACOSX) 64 #if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_WIN)
65 #define MAYBE_WebRtcAudioQualityBrowserTest WebRtcAudioQualityBrowserTest 65 #define MAYBE_WebRtcAudioQualityBrowserTest WebRtcAudioQualityBrowserTest
66 #else 66 #else
67 // Not implemented on Android, ChromeOS etc. 67 // Not implemented on Android, ChromeOS etc.
68 // Disabled on win while bots are configured: http://crbug.com/625808.
69 #define MAYBE_WebRtcAudioQualityBrowserTest DISABLED_WebRtcAudioQualityBrowserTe st 68 #define MAYBE_WebRtcAudioQualityBrowserTest DISABLED_WebRtcAudioQualityBrowserTe st
70 #endif 69 #endif
71 70
72 } // namespace 71 } // namespace
73 72
74 // Test we can set up a WebRTC call and play audio through it. 73 // Test we can set up a WebRTC call and play audio through it.
75 // 74 //
76 // If you're not a googler and want to run this test, you need to provide a 75 // If you're not a googler and want to run this test, you need to provide a
77 // pesq binary for your platform (and sox.exe on windows). Read more on how 76 // pesq binary for your platform (and sox.exe on windows). Read more on how
78 // resources are managed in chrome/test/data/webrtc/resources/README. 77 // resources are managed in chrome/test/data/webrtc/resources/README.
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
797 DeleteFileUnlessTestFailed(actual_files_dir, true); 796 DeleteFileUnlessTestFailed(actual_files_dir, true);
798 } 797 }
799 798
800 // The AGC should apply non-zero gain here. 799 // The AGC should apply non-zero gain here.
801 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest, 800 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest,
802 MANUAL_TestAutoGainControlOnLowAudio) { 801 MANUAL_TestAutoGainControlOnLowAudio) {
803 ASSERT_NO_FATAL_FAILURE(TestAutoGainControl( 802 ASSERT_NO_FATAL_FAILURE(TestAutoGainControl(
804 kReferenceFile, kAudioOnlyCallConstraints, "_with_agc")); 803 kReferenceFile, kAudioOnlyCallConstraints, "_with_agc"));
805 } 804 }
806 805
806 // The test is failing on the Win7 bot.
807 // http://crbug.com/625808#c23
808 #if defined(OS_WIN)
809 #define MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff\
810 DISABLED_TestAutoGainIsOffWithAudioProcessingOff
811 #else
812 #define MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff\
813 MANUAL_TestAutoGainIsOffWithAudioProcessingOff
814 #endif
807 // Since the AGC is off here there should be no gain at all. 815 // Since the AGC is off here there should be no gain at all.
808 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest, 816 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest,
809 MANUAL_TestAutoGainIsOffWithAudioProcessingOff) { 817 MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff) {
810 const char* kAudioCallWithoutAudioProcessing = 818 const char* kAudioCallWithoutAudioProcessing =
811 "{audio: { mandatory: { echoCancellation: false } } }"; 819 "{audio: { mandatory: { echoCancellation: false } } }";
812 ASSERT_NO_FATAL_FAILURE(TestAutoGainControl( 820 ASSERT_NO_FATAL_FAILURE(TestAutoGainControl(
813 kReferenceFile, kAudioCallWithoutAudioProcessing, "_no_agc")); 821 kReferenceFile, kAudioCallWithoutAudioProcessing, "_no_agc"));
814 } 822 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698