Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: net/cert/sct_status_flags.h

Issue 2241213002: Distinguish between SCT invalidity reasons in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changing _MAX to be the last value Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/multi_log_ct_verifier.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/sct_status_flags.h
diff --git a/net/cert/sct_status_flags.h b/net/cert/sct_status_flags.h
index 123c25c89052acf0ca3e915d57555b452b04617b..ac0bc7d7e6716793c9911833fc089eff881818a9 100644
--- a/net/cert/sct_status_flags.h
+++ b/net/cert/sct_status_flags.h
@@ -21,14 +21,22 @@ enum SCTVerifyStatus {
// The SCT is from an unknown log, so we cannot verify its signature.
SCT_STATUS_LOG_UNKNOWN = 1,
- // The SCT is from a known log, but the signature is invalid.
- SCT_STATUS_INVALID = 2,
+ // SCTVerifyStatus=2 used to represent SCT_STATUS_INVALID, which has now been
+ // split into INVALID_SIGNATURE and INVALID_TIMESTAMP to represent the
+ // different reasons an SCT could be invalid.
// The SCT is from a known log, and the signature is valid.
SCT_STATUS_OK = 3,
- // Used to bound the enum values.
- SCT_STATUS_MAX,
+ // The SCT is from a known log, but the signature is invalid.
+ SCT_STATUS_INVALID_SIGNATURE = 4,
+
+ // The SCT is from a known log, but the timestamp is in the future.
+ SCT_STATUS_INVALID_TIMESTAMP = 5,
+
+ // Used to bound the enum values. Since this enum is passed over IPC,
+ // the last value must be a valid one (rather than one past a valid one).
+ SCT_STATUS_MAX = SCT_STATUS_INVALID_TIMESTAMP,
};
} // namespace ct
« no previous file with comments | « net/cert/multi_log_ct_verifier.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698