Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: net/cert/sct_status_flags.h

Issue 2241213002: Distinguish between SCT invalidity reasons in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changing _MAX to be the last value Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cert/multi_log_ct_verifier.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_CERT_SCT_STATUS_FLAGS_H_ 5 #ifndef NET_CERT_SCT_STATUS_FLAGS_H_
6 #define NET_CERT_SCT_STATUS_FLAGS_H_ 6 #define NET_CERT_SCT_STATUS_FLAGS_H_
7 7
8 namespace net { 8 namespace net {
9 9
10 namespace ct { 10 namespace ct {
11 11
12 // The possible verification statuses for a SignedCertificateTimestamp. 12 // The possible verification statuses for a SignedCertificateTimestamp.
13 // Note: The numeric values are used within histograms and should not change 13 // Note: The numeric values are used within histograms and should not change
14 // or be re-assigned. 14 // or be re-assigned.
15 enum SCTVerifyStatus { 15 enum SCTVerifyStatus {
16 // Not a real status, this just prevents a default int value from being 16 // Not a real status, this just prevents a default int value from being
17 // mis-interpreseted as a valid status. 17 // mis-interpreseted as a valid status.
18 // Also used to count SCTs that cannot be decoded in the histogram. 18 // Also used to count SCTs that cannot be decoded in the histogram.
19 SCT_STATUS_NONE = 0, 19 SCT_STATUS_NONE = 0,
20 20
21 // The SCT is from an unknown log, so we cannot verify its signature. 21 // The SCT is from an unknown log, so we cannot verify its signature.
22 SCT_STATUS_LOG_UNKNOWN = 1, 22 SCT_STATUS_LOG_UNKNOWN = 1,
23 23
24 // The SCT is from a known log, but the signature is invalid. 24 // SCTVerifyStatus=2 used to represent SCT_STATUS_INVALID, which has now been
25 SCT_STATUS_INVALID = 2, 25 // split into INVALID_SIGNATURE and INVALID_TIMESTAMP to represent the
26 // different reasons an SCT could be invalid.
26 27
27 // The SCT is from a known log, and the signature is valid. 28 // The SCT is from a known log, and the signature is valid.
28 SCT_STATUS_OK = 3, 29 SCT_STATUS_OK = 3,
29 30
30 // Used to bound the enum values. 31 // The SCT is from a known log, but the signature is invalid.
31 SCT_STATUS_MAX, 32 SCT_STATUS_INVALID_SIGNATURE = 4,
33
34 // The SCT is from a known log, but the timestamp is in the future.
35 SCT_STATUS_INVALID_TIMESTAMP = 5,
36
37 // Used to bound the enum values. Since this enum is passed over IPC,
38 // the last value must be a valid one (rather than one past a valid one).
39 SCT_STATUS_MAX = SCT_STATUS_INVALID_TIMESTAMP,
32 }; 40 };
33 41
34 } // namespace ct 42 } // namespace ct
35 43
36 } // namespace net 44 } // namespace net
37 45
38 #endif // NET_CERT_SCT_STATUS_FLAGS_H_ 46 #endif // NET_CERT_SCT_STATUS_FLAGS_H_
OLDNEW
« no previous file with comments | « net/cert/multi_log_ct_verifier.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698