Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2241213002: Distinguish between SCT invalidity reasons in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: A patchset that actually works Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« net/cert/sct_status_flags.h ('K') | « net/cert/sct_status_flags.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 87938098d312bf886360bf03d6ebd92f53b04a74..a44a9dfb5b3a0428893e71a092d7a5d96e5d6741 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -91508,8 +91508,9 @@ To add a new entry, add it with any value and run test to compute valid value.
<enum name="SCTVerifyStatus" type="int">
<int value="0" label="SCT_STATUS_NONE"/>
<int value="1" label="SCT_STATUS_LOG_UNKNOWN"/>
- <int value="2" label="SCT_STATUS_INVALID"/>
estark 2016/08/15 13:22:08 A histograms owner will tell you for sure but it l
Eran Messeri 2016/08/16 14:17:18 Added back the invalid status, prefixing with DEPR
<int value="3" label="SCT_STATUS_OK"/>
+ <int value="4" label="SCT_STATUS_INVALID_SIGNATURE"/>
+ <int value="5" label="SCT_STATUS_INVALID_TIMESTAMP"/>
</enum>
<enum name="SdchDictionaryFate" type="int">
« net/cert/sct_status_flags.h ('K') | « net/cert/sct_status_flags.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698