Distinguish between SCT invalidity reasons in UMA

net/cert/sct_status_flags.h

Index: net/cert/sct_status_flags.h
diff --git a/net/cert/sct_status_flags.h b/net/cert/sct_status_flags.h
index 123c25c89052acf0ca3e915d57555b452b04617b..41673bd541c661de6b694509b7f7fca9c5a8b616 100644
--- a/net/cert/sct_status_flags.h
+++ b/net/cert/sct_status_flags.h
@@ -21,12 +21,15 @@ enum SCTVerifyStatus {
   // The SCT is from an unknown log, so we cannot verify its signature.
   SCT_STATUS_LOG_UNKNOWN = 1,
 

[estark, 2016/08/15 13:22:08]

Maybe leave a comment here to indicate that 2 used to exist but is obsolete now:
"SCTVerifyStatus=2 used to represent SCT_STATUS_INVALID, which has now been
split into INVALID_SIGNATURE and INVALID_TIMESTAMP to represent the different
reasons an SCT could be invalid."
(or something like that)

[Eran Messeri, 2016/08/16 14:17:18]

Done, thanks for the text.

-  // The SCT is from a known log, but the signature is invalid.
-  SCT_STATUS_INVALID = 2,
-
   // The SCT is from a known log, and the signature is valid.
   SCT_STATUS_OK = 3,
 
+  // The SCT is from a known log, but the signature is invalid.
+  SCT_STATUS_INVALID_SIGNATURE = 4,
+
+  // The SCT is from a known log, but the timestamp is in the future.
+  SCT_STATUS_INVALID_TIMESTAMP = 5,
+
   // Used to bound the enum values.
   SCT_STATUS_MAX,
 };