Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Unified Diff: extensions/common/features/simple_feature.h

Issue 2241203003: Pass user session type to extension feature checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: split out some stuff Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/features/simple_feature.h
diff --git a/extensions/common/features/simple_feature.h b/extensions/common/features/simple_feature.h
index fb931562298d7780739ed0c411a69535105ae1cb..d5d637820889e36b0676d179df0a53caf30a0813 100644
--- a/extensions/common/features/simple_feature.h
+++ b/extensions/common/features/simple_feature.h
@@ -57,18 +57,23 @@ class SimpleFeature : public Feature {
virtual bool Validate(std::string* error);
Availability IsAvailableToContext(const Extension* extension,
- Context context) const {
- return IsAvailableToContext(extension, context, GURL());
+ Context context,
+ SessionType session_type) const {
+ return IsAvailableToContext(extension, context, session_type, GURL());
}
Availability IsAvailableToContext(const Extension* extension,
Context context,
+ SessionType session_type,
Platform platform) const {
- return IsAvailableToContext(extension, context, GURL(), platform);
+ return IsAvailableToContext(extension, context, session_type, GURL(),
+ platform);
}
Availability IsAvailableToContext(const Extension* extension,
Context context,
+ SessionType session_type,
const GURL& url) const {
- return IsAvailableToContext(extension, context, url, GetCurrentPlatform());
+ return IsAvailableToContext(extension, context, session_type, url,
+ GetCurrentPlatform());
}
// extension::Feature:
@@ -79,6 +84,7 @@ class SimpleFeature : public Feature {
Platform platform) const override;
Availability IsAvailableToContext(const Extension* extension,
Context context,
+ SessionType session_type,
const GURL& url,
Platform platform) const override;
bool IsInternal() const override;

Powered by Google App Engine
This is Rietveld 408576698