Pass user session type to extension feature checks

extensions/common/extension_api.h

Index: extensions/common/extension_api.h
diff --git a/extensions/common/extension_api.h b/extensions/common/extension_api.h
index b8dee559e4b137d5f5d9bce923ae2eb072e0cfea..d66a4da6c6743c697869435985e099f9fca7395d 100644
--- a/extensions/common/extension_api.h
+++ b/extensions/common/extension_api.h
@@ -95,6 +95,7 @@ class ExtensionAPI {
   Feature::Availability IsAvailable(const std::string& api_full_name,
                                     const Extension* extension,
                                     Feature::Context context,
+                                    Feature::SessionType session_type,

[Devlin, 2016/08/17 17:07:35]

The session type can't really change, right?  Why doesn't feature code determine
what it is rather than having it passed it?

[tbarzic, 2016/08/17 19:49:01]

It can change from UNSPECIFIED when a user logs in (so, effectively it should be
constant; except in signin profile on ChromeOS, for which session type should
not be important).

                                     const GURL& url);
 
   // Determines whether an API, or any parts of that API, are available in
@@ -102,10 +103,13 @@ class ExtensionAPI {
   bool IsAnyFeatureAvailableToContext(const Feature& api,
                                       const Extension* extension,
                                       Feature::Context context,
+                                      Feature::SessionType session_type,
                                       const GURL& url);
 
   // Returns true if |name| is available to WebUI contexts on |url|.
-  bool IsAvailableToWebUI(const std::string& name, const GURL& url);
+  bool IsAvailableToWebUI(const std::string& name,
+                          Feature::SessionType session_type,
+                          const GURL& url);
 
   // Gets the schema for the extension API with namespace |full_name|.
   // Ownership remains with this object.