Pass user session type to extension feature checks

extensions/common/extension_api.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_EXTENSION_API_H_
 #define EXTENSIONS_COMMON_EXTENSION_API_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 77 matching lines @@
   // Depending on the configuration of |api| (in _api_features.json), either
   // |extension| or |url| (or both) may determine its availability, but this is
   // up to the configuration of the individual feature.
   //
   // TODO(kalman): This is just an unnecessary combination of finding a Feature
   // then calling Feature::IsAvailableToContext(..) on it. Just provide that
   // FindFeature function and let callers compose if they want.
   Feature::Availability IsAvailable(const std::string& api_full_name,
                                     const Extension* extension,
                                     Feature::Context context,
+                                    Feature::SessionType session_type,

[Devlin, 2016/08/17 17:07:35]

The session type can't really change, right?  Why doesn't feature code determine
what it is rather than having it passed it?

[tbarzic, 2016/08/17 19:49:01]

It can change from UNSPECIFIED when a user logs in (so, effectively it should be
constant; except in signin profile on ChromeOS, for which session type should
not be important).

                                     const GURL& url);
 
   // Determines whether an API, or any parts of that API, are available in
   // |context|.
   bool IsAnyFeatureAvailableToContext(const Feature& api,
                                       const Extension* extension,
                                       Feature::Context context,
+                                      Feature::SessionType session_type,
                                       const GURL& url);
 
   // Returns true if |name| is available to WebUI contexts on |url|.
-  bool IsAvailableToWebUI(const std::string& name, const GURL& url);
+  bool IsAvailableToWebUI(const std::string& name,
+                          Feature::SessionType session_type,
+                          const GURL& url);
 
   // Gets the schema for the extension API with namespace |full_name|.
   // Ownership remains with this object.
   const base::DictionaryValue* GetSchema(const std::string& full_name);
 
   // Splits a full name from the extension API into its API and child name
   // parts. Some examples:
   //
   // "bookmarks.create" -> ("bookmarks", "create")
   // "experimental.input.ui.cursorUp" -> ("experimental.input.ui", "cursorUp")
@@ skipping 33 matching lines @@
   // FeatureProviders used for resolving dependencies.
   typedef std::map<std::string, const FeatureProvider*> FeatureProviderMap;
   FeatureProviderMap dependency_providers_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionAPI);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_EXTENSION_API_H_