Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

Issue 2241193004: Fix a crash: SlotAssignment is unintentionally created for v0 shadow trees (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
index b9a007902c98a82c3678e6e6e59269d1e7438639..7998d036960d83beca721cd173d0c9ccda3bc64f 100644
--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
@@ -233,7 +233,7 @@ Node::InsertionNotificationRequest HTMLSlotElement::insertedInto(ContainerNode*
root->owner()->setNeedsDistributionRecalc();
// Relevant DOM Standard: https://dom.spec.whatwg.org/#concept-node-insert
// - 6.4: Run assign slotables for a tree with node's tree and a set containing each inclusive descendant of node that is a slot.
- if (!wasInShadowTreeBeforeInserted(*this, *insertionPoint))
+ if (root->isV1() && !wasInShadowTreeBeforeInserted(*this, *insertionPoint))
root->ensureSlotAssignment().slotAdded(*this);
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698