third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp - Issue 2241193004: Fix a crash: SlotAssignment is unintentionally created for v0 shadow trees

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

Issue 2241193004: Fix a crash: SlotAssignment is unintentionally created for v0 shadow trees (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/crashes/slots-in-v0-crash.html ('k') | third_party/WebKit/Source/core/html/HTMLSlotElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

index 0d86721f8884f556cc0296ad22af405e5f60e53e..37567a189d1e54433265c49d600bf5729a061348 100644

--- a/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

@@ -105,6 +105,7 @@ SlotAssignment::SlotAssignment(ShadowRoot& owner)

, m_needsCollectSlots(false)

, m_slotCount(0)

{

+ DCHECK(owner.isV1());

}

static void detachNotAssignedNode(Node& node)