Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 224113006: Apply OwnPtr|PassOwnPtr to member variables and arguments in ContextFeatures. (Closed)

Created:
6 years, 8 months ago by gyuyoung-inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Apply OwnPtr|PassOwnPtr to member variables and arguments in ContextFeatures. WebViewImpl has used m_featureSwitchClient unnecessarily in order to pass it to provideContextFeaturesTo(). To remove it, we need to apply OwnPtr|PassOwnPtr to member variable and parameter types. Additionally m_midiClientProxy should be removed because it wasn't removed in r170746. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170877

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -27 lines) Patch
M Source/core/dom/ContextFeatures.h View 1 2 chunks +6 lines, -14 lines 0 comments Download
M Source/core/dom/ContextFeatures.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M Source/web/ContextFeaturesClientImpl.h View 1 chunk +6 lines, -1 line 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/WebViewImpl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gyuyoung-inactive
6 years, 8 months ago (2014-04-03 16:45:56 UTC) #1
jochen (gone - plz use gerrit)
also, what will delete the pointer? https://codereview.chromium.org/224113006/diff/1/Source/web/WebViewImpl.cpp File Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/224113006/diff/1/Source/web/WebViewImpl.cpp#newcode396 Source/web/WebViewImpl.cpp:396: provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create().get()); won't ...
6 years, 8 months ago (2014-04-04 09:07:01 UTC) #2
gyuyoung-inactive
https://codereview.chromium.org/224113006/diff/1/Source/web/WebViewImpl.cpp File Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/224113006/diff/1/Source/web/WebViewImpl.cpp#newcode396 Source/web/WebViewImpl.cpp:396: provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create().get()); On 2014/04/04 09:07:01, jochen wrote: > won't ...
6 years, 8 months ago (2014-04-04 09:51:10 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-04 10:29:09 UTC) #4
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-04-04 13:17:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/224113006/20001
6 years, 8 months ago (2014-04-04 13:18:02 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 16:06:23 UTC) #7
Message was sent while issue was closed.
Change committed as 170877

Powered by Google App Engine
This is Rietveld 408576698