Source/web/WebPagePopupImpl.cpp - Issue 224113006: Apply OwnPtr|PassOwnPtr to member variables and arguments in ContextFeatures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 224113006: Apply OwnPtr|PassOwnPtr to member variables and arguments in ContextFeatures. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPagePopupImpl.cpp

diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp

index 010344573f7e516f710bf7d0f402c2ed91a4ac13..6614aeae651187b7bbe1f25ff553c7b808b8c03e 100644

--- a/Source/web/WebPagePopupImpl.cpp

+++ b/Source/web/WebPagePopupImpl.cpp

@@ -210,8 +210,7 @@ bool WebPagePopupImpl::initializePage()

m_page->setDeviceScaleFactor(m_webView->deviceScaleFactor());

m_page->settings().setDeviceSupportsTouch(m_webView->page()->settings().deviceSupportsTouch());

- static ContextFeaturesClient* pagePopupFeaturesClient = new PagePopupFeaturesClient();

- provideContextFeaturesTo(*m_page, pagePopupFeaturesClient);

+ provideContextFeaturesTo(*m_page, adoptPtr(new PagePopupFeaturesClient()));

static FrameLoaderClient* emptyFrameLoaderClient = new EmptyFrameLoaderClient();

RefPtr<LocalFrame> frame = LocalFrame::create(emptyFrameLoaderClient, &m_page->frameHost(), 0);

frame->setView(FrameView::create(frame.get()));

« no previous file with comments | « Source/web/ContextFeaturesClientImpl.h ('k') | Source/web/WebViewImpl.h » ('j') | no next file with comments »