Source/web/tests/WebFrameTest.cpp - Issue 224113002: Oilpan: move Range object to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 224113002: Oilpan: move Range object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use STACK_ALLOCATED() + incorporate ager's overview of macros in this area. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 7fccce6d6c5705ab477f68b08a6af83cb7e7a262..8e2cfe7cb04fbb6b23d71baaa0615f94f08cd0a1 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -4220,7 +4220,7 @@ TEST_F(WebFrameTest, ReplaceMisspelledRange)

const int allTextBeginOffset = 0;

const int allTextLength = 11;

frame->selectRange(WebRange::fromDocumentRange(frame, allTextBeginOffset, allTextLength));

- RefPtr<Range> selectionRange = frame->frame()->selection().toNormalizedRange();

+ RefPtrWillBeRawPtr<Range> selectionRange = frame->frame()->selection().toNormalizedRange();

EXPECT_EQ(1, spellcheck.numberOfTimesChecked());

EXPECT_EQ(1U, document->markers().markersInRange(selectionRange.get(), DocumentMarker::Spelling).size());

@@ -4253,7 +4253,7 @@ TEST_F(WebFrameTest, RemoveSpellingMarkers)

const int allTextBeginOffset = 0;

const int allTextLength = 11;

frame->selectRange(WebRange::fromDocumentRange(frame, allTextBeginOffset, allTextLength));

- RefPtr<Range> selectionRange = frame->frame()->selection().toNormalizedRange();

+ RefPtrWillBeRawPtr<Range> selectionRange = frame->frame()->selection().toNormalizedRange();

EXPECT_EQ(0U, document->markers().markersInRange(selectionRange.get(), DocumentMarker::Spelling).size());

}