Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1842)

Unified Diff: Source/web/mac/WebSubstringUtil.mm

Issue 224113002: Oilpan: move Range object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use STACK_ALLOCATED() + incorporate ager's overview of macros in this area. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/mac/WebSubstringUtil.mm
diff --git a/Source/web/mac/WebSubstringUtil.mm b/Source/web/mac/WebSubstringUtil.mm
index 6e50c37ca0a601fd9881533b4e003504817e1069..216d9983a28b3096b21d3eaae4dde7af8099ea6d 100644
--- a/Source/web/mac/WebSubstringUtil.mm
+++ b/Source/web/mac/WebSubstringUtil.mm
@@ -116,14 +116,14 @@ NSAttributedString* WebSubstringUtil::attributedWordAtPoint(WebView* view, WebPo
LocalFrame* frame = result.targetNode()->document().frame();
FrameView* frameView = frame->view();
- RefPtr<Range> range = frame->rangeForPoint(result.roundedPointInInnerNodeFrame());
+ RefPtrWillBeRawPtr<Range> range = frame->rangeForPoint(result.roundedPointInInnerNodeFrame());
if (!range)
return nil;
// Expand to word under point.
VisibleSelection selection(range.get());
selection.expandUsingGranularity(WordGranularity);
- RefPtr<Range> wordRange = selection.toNormalizedRange();
+ RefPtrWillBeRawPtr<Range> wordRange = selection.toNormalizedRange();
// Convert to NSAttributedString.
NSAttributedString* string = attributedSubstringFromRange(wordRange.get());
@@ -153,7 +153,7 @@ NSAttributedString* WebSubstringUtil::attributedSubstringInRange(WebFrame* webFr
Element* editable = frame->selection().rootEditableElementOrDocumentElement();
ASSERT(editable);
- RefPtr<Range> range(PlainTextRange(location, location + length).createRange(*editable));
+ RefPtrWillBeRawPtr<Range> range(PlainTextRange(location, location + length).createRange(*editable));
if (!range)
return nil;

Powered by Google App Engine
This is Rietveld 408576698