Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: Source/core/editing/FrameSelection.h

Issue 224113002: Oilpan: move Range object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use STACK_ALLOCATED() + incorporate ager's overview of macros in this area. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/FrameSelection.h
diff --git a/Source/core/editing/FrameSelection.h b/Source/core/editing/FrameSelection.h
index cd32a53c279c40f4cfff4363abe6e26da59c9758..d4eefe515b79b5a6c179afcb842c55044e4abcde 100644
--- a/Source/core/editing/FrameSelection.h
+++ b/Source/core/editing/FrameSelection.h
@@ -147,9 +147,9 @@ public:
// If this FrameSelection has a logical range which is still valid, this function return its clone. Otherwise,
// the return value from underlying VisibleSelection's firstRange() is returned.
- PassRefPtr<Range> firstRange() const;
+ PassRefPtrWillBeRawPtr<Range> firstRange() const;
- PassRefPtr<Range> toNormalizedRange() const { return m_selection.toNormalizedRange(); }
+ PassRefPtrWillBeRawPtr<Range> toNormalizedRange() const { return m_selection.toNormalizedRange(); }
void nodeWillBeRemoved(Node&);
void didUpdateCharacterData(CharacterData*, unsigned offset, unsigned oldLength, unsigned newLength);
@@ -258,7 +258,7 @@ private:
// The range specified by the user, which may not be visually canonicalized (hence "logical").
// This will be invalidated if the underlying VisibleSelection changes. If that happens, this variable will
// become null, in which case logical positions == visible positions.
- RefPtr<Range> m_logicalRange;
+ RefPtrWillBePersistent<Range> m_logicalRange;
RefPtr<Node> m_previousCaretNode; // The last node which painted the caret. Retained for clearing the old caret when it moves.

Powered by Google App Engine
This is Rietveld 408576698