Source/core/editing/FormatBlockCommand.cpp - Issue 224113002: Oilpan: move Range object to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FormatBlockCommand.cpp

Issue 224113002: Oilpan: move Range object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use STACK_ALLOCATED() + incorporate ager's overview of macros in this area. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/FormatBlockCommand.cpp

diff --git a/Source/core/editing/FormatBlockCommand.cpp b/Source/core/editing/FormatBlockCommand.cpp

index 2c2d26aa05d04c32fd3eac3ec8507bc8652b0c11..13510e43137fc33a75f0a340b337277a84f8b3d2 100644

--- a/Source/core/editing/FormatBlockCommand.cpp

+++ b/Source/core/editing/FormatBlockCommand.cpp

@@ -70,7 +70,7 @@ void FormatBlockCommand::formatRange(const Position& start, const Position& end,

Node* nodeToSplitTo = enclosingBlockToSplitTreeTo(start.deprecatedNode());

RefPtr<Node> outerBlock = (start.deprecatedNode() == nodeToSplitTo) ? start.deprecatedNode() : splitTreeToNode(start.deprecatedNode(), nodeToSplitTo);

RefPtr<Node> nodeAfterInsertionPosition = outerBlock;

- RefPtr<Range> range = Range::create(document(), start, endOfSelection);

+ RefPtrWillBeRawPtr<Range> range = Range::create(document(), start, endOfSelection);

if (isElementForFormatBlock(refNode->tagQName()) && VisiblePosition(start) == startOfBlock(VisiblePosition(start))

&& (VisiblePosition(end) == endOfBlock(VisiblePosition(end)) || isNodeVisiblyContainedWithin(*refNode, *range))

« Source/core/editing/EditorCommand.cpp ('K') | « Source/core/editing/EditorCommand.cpp ('k') | Source/core/editing/FrameSelection.h » ('j') | no next file with comments »