Source/core/editing/EditingStyle.cpp - Issue 224113002: Oilpan: move Range object to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/EditingStyle.cpp

Issue 224113002: Oilpan: move Range object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use STACK_ALLOCATED() + incorporate ager's overview of macros in this area. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/EditingStyle.cpp

diff --git a/Source/core/editing/EditingStyle.cpp b/Source/core/editing/EditingStyle.cpp

index 2d13115a59e9be5dddf6cdfdaeb69720b58165f0..e9b1d7be9d7c741d511bcb21f66e7d1910cf7650 100644

--- a/Source/core/editing/EditingStyle.cpp

+++ b/Source/core/editing/EditingStyle.cpp

@@ -1258,7 +1258,7 @@ PassRefPtr<EditingStyle> EditingStyle::styleAtSelectionStart(const VisibleSelect

// Also, if the selection is a range, ignore the background color at the start of selection,

// and find the background color of the common ancestor.

if (shouldUseBackgroundColorInEffect && (selection.isRange() || hasTransparentBackgroundColor(style->m_mutableStyle.get()))) {

- RefPtr<Range> range(selection.toNormalizedRange());

+ RefPtrWillBeRawPtr<Range> range(selection.toNormalizedRange());

if (PassRefPtrWillBeRawPtr<CSSValue> value = backgroundColorInEffect(range->commonAncestorContainer(IGNORE_EXCEPTION)))

style->setProperty(CSSPropertyBackgroundColor, value->cssText());

}