Source/core/editing/DeleteSelectionCommand.cpp - Issue 224113002: Oilpan: move Range object to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/DeleteSelectionCommand.cpp

Issue 224113002: Oilpan: move Range object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use STACK_ALLOCATED() + incorporate ager's overview of macros in this area. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/DeleteSelectionCommand.cpp

diff --git a/Source/core/editing/DeleteSelectionCommand.cpp b/Source/core/editing/DeleteSelectionCommand.cpp

index fd7a7e3bf35195d17689b6a158d1517320667601..48ef864969a3969c7ac49e1707e92987d81854d9 100644

--- a/Source/core/editing/DeleteSelectionCommand.cpp

+++ b/Source/core/editing/DeleteSelectionCommand.cpp

@@ -418,7 +418,7 @@ void DeleteSelectionCommand::deleteTextFromNode(PassRefPtr<Text> node, unsigned

void DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss()

{

- RefPtr<Range> range = m_selectionToDelete.toNormalizedRange();

+ RefPtrWillBeRawPtr<Range> range = m_selectionToDelete.toNormalizedRange();

RefPtr<Node> node = range->firstNode();

while (node && node != range->pastLastNode()) {

RefPtr<Node> nextNode = NodeTraversal::next(*node);