Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2241073002: Revert of Disable flaky MetricsServiceBrowserTest#CloseRenderersNormally. (Closed)

Created:
4 years, 4 months ago by Alexei Svitkine (slow)
Modified:
4 years, 4 months ago
Reviewers:
esprehn
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky MetricsServiceBrowserTest#CloseRenderersNormally. (patchset #1 id:1 of https://codereview.chromium.org/2231443003/ ) Reason for revert: Re-enabling test given the underlying issue has been fixed. Original issue's description: > Disable flaky MetricsServiceBrowserTest#CloseRenderersNormally. > > BUG=636052 > TBR=asvitkine@chromium.org > > Committed: https://crrev.com/f0b0de291ba041ed4bb40a0e3ead7d8324acdd49 > Cr-Commit-Position: refs/heads/master@{#410830} TBR=esprehn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636052 Committed: https://crrev.com/574fe529a9e808c41489f6b2acf6c9b835e90e8e Cr-Commit-Position: refs/heads/master@{#411840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/metrics/metrics_service_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Alexei Svitkine (slow)
Created Revert of Disable flaky MetricsServiceBrowserTest#CloseRenderersNormally.
4 years, 4 months ago (2016-08-13 00:09:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241073002/1
4 years, 4 months ago (2016-08-13 00:10:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-13 01:03:44 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 01:08:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/574fe529a9e808c41489f6b2acf6c9b835e90e8e
Cr-Commit-Position: refs/heads/master@{#411840}

Powered by Google App Engine
This is Rietveld 408576698