Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Unified Diff: chrome/browser/metrics/metrics_service_browsertest.cc

Issue 2241073002: Revert of Disable flaky MetricsServiceBrowserTest#CloseRenderersNormally. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service_browsertest.cc
diff --git a/chrome/browser/metrics/metrics_service_browsertest.cc b/chrome/browser/metrics/metrics_service_browsertest.cc
index 9f329da363e37c1aaf116ca18321c97fe05c6f51..740f6ba76c1ec7b5b34b1190f66d85e4d7073bbf 100644
--- a/chrome/browser/metrics/metrics_service_browsertest.cc
+++ b/chrome/browser/metrics/metrics_service_browsertest.cc
@@ -60,14 +60,7 @@
}
};
-// Flaky failing DCHECK on Windows, see crbug.com/636052
-#if defined(OS_WIN)
-#define MAYBE_CloseRenderersNormally DISABLED_CloseRenderersNormally
-#else
-#define MAYBE_CloseRenderersNormally CloseRenderersNormally
-#endif
-IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserTest,
- MAYBE_CloseRenderersNormally) {
+IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserTest, CloseRenderersNormally) {
OpenTabs();
// Verify that the expected stability metrics were recorded.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698