Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: tests/compiler/dart2js/sourcemaps/diff_view.dart

Issue 2241033002: More bot fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/serialization/model_test_helper.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/sourcemaps/diff_view.dart
diff --git a/tests/compiler/dart2js/sourcemaps/diff_view.dart b/tests/compiler/dart2js/sourcemaps/diff_view.dart
index 1c1090a52eaeba36cf4df0c9e4776a107bdf8d75..adeb6417a89477c8acb5e9dd35e466e179034815 100644
--- a/tests/compiler/dart2js/sourcemaps/diff_view.dart
+++ b/tests/compiler/dart2js/sourcemaps/diff_view.dart
@@ -65,11 +65,13 @@ main(List<String> args) async {
List<String> commonArguments = optionSegments[0];
List<List<String>> options = <List<String>>[];
if (optionSegments.length == 1) {
+ // TODO(sigmund, johnniwinther): change default options now that CPS is
+ // deleted.
// Use default options; comparing SSA and CPS output using the new
// source information strategy.
options.add([Flags.useNewSourceInfo]..addAll(commonArguments));
- options.add(
- [Flags.useNewSourceInfo, Flags.useCpsIr]..addAll(commonArguments));
+ options.add([Flags.useNewSourceInfo]..addAll(commonArguments));
+ throw "missing options: please specify options for the second column";
} else if (optionSegments.length == 2) {
// Use alternative options for the second output column.
options.add(commonArguments);
« no previous file with comments | « tests/compiler/dart2js/serialization/model_test_helper.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698