Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: tests/compiler/dart2js/sourcemaps/diff_view.dart

Issue 2241033002: More bot fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/compiler/dart2js/serialization/model_test_helper.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library sourcemap.diff_view; 5 library sourcemap.diff_view;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:convert'; 8 import 'dart:convert';
9 import 'dart:io'; 9 import 'dart:io';
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 out = arg.substring('--out='.length); 58 out = arg.substring('--out='.length);
59 } else if (arg.startsWith('-')) { 59 } else if (arg.startsWith('-')) {
60 currentOptions.add(arg); 60 currentOptions.add(arg);
61 } else { 61 } else {
62 filename = arg; 62 filename = arg;
63 } 63 }
64 } 64 }
65 List<String> commonArguments = optionSegments[0]; 65 List<String> commonArguments = optionSegments[0];
66 List<List<String>> options = <List<String>>[]; 66 List<List<String>> options = <List<String>>[];
67 if (optionSegments.length == 1) { 67 if (optionSegments.length == 1) {
68 // TODO(sigmund, johnniwinther): change default options now that CPS is
69 // deleted.
68 // Use default options; comparing SSA and CPS output using the new 70 // Use default options; comparing SSA and CPS output using the new
69 // source information strategy. 71 // source information strategy.
70 options.add([Flags.useNewSourceInfo]..addAll(commonArguments)); 72 options.add([Flags.useNewSourceInfo]..addAll(commonArguments));
71 options.add( 73 options.add([Flags.useNewSourceInfo]..addAll(commonArguments));
72 [Flags.useNewSourceInfo, Flags.useCpsIr]..addAll(commonArguments)); 74 throw "missing options: please specify options for the second column";
73 } else if (optionSegments.length == 2) { 75 } else if (optionSegments.length == 2) {
74 // Use alternative options for the second output column. 76 // Use alternative options for the second output column.
75 options.add(commonArguments); 77 options.add(commonArguments);
76 options.add(optionSegments[1]..addAll(commonArguments)); 78 options.add(optionSegments[1]..addAll(commonArguments));
77 } else { 79 } else {
78 // Use specific options for both output columns. 80 // Use specific options for both output columns.
79 options.add(optionSegments[1]..addAll(commonArguments)); 81 options.add(optionSegments[1]..addAll(commonArguments));
80 options.add(optionSegments[2]..addAll(commonArguments)); 82 options.add(optionSegments[2]..addAll(commonArguments));
81 } 83 }
82 84
(...skipping 907 matching lines...) Expand 10 before | Expand all | Expand 10 after
990 return new AnnotationData( 992 return new AnnotationData(
991 tag: 'span', 993 tag: 'span',
992 properties: { 994 properties: {
993 'title': annotation.title, 995 'title': annotation.title,
994 'class': '${ClassNames.marker} ' 996 'class': '${ClassNames.marker} '
995 '${data.annotationType.className}'}); 997 '${data.annotationType.className}'});
996 } 998 }
997 } 999 }
998 return null; 1000 return null;
999 } 1001 }
OLDNEW
« no previous file with comments | « tests/compiler/dart2js/serialization/model_test_helper.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698