Mac: Loosen CoreAnimation blacklist on 10.10 and histograms to watch

Mac: Loosen CoreAnimation blacklist on 10.10 and histograms to watch

This was only ever observed on this particular GPU.

Add histograms to watch glFlush and CATransaction time, since they
(in addition to IOSurface create and texture bind) are places where we
see hangs.

BUG=580616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b9bc972508ad89ce3a9c6b1045b725cd23646c5e
Cr-Commit-Position: refs/heads/master@{#412012}

[ccameron, 2016-08-12 21:40:07]

Description was changed from

==========
Mac: Loosen CoreAnimation blacklist on 10.10 and histograms to watch

BUG=
==========

to

==========
Mac: Loosen CoreAnimation blacklist on 10.10 and histograms to watch

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-08-12 21:44:58]

Description was changed from

==========
Mac: Loosen CoreAnimation blacklist on 10.10 and histograms to watch

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Mac: Loosen CoreAnimation blacklist on 10.10 and histograms to watch

This was only ever observed on this particular GPU.

Add histograms to watch glFlush and CATransaction time, since they
(in addition to IOSurface create and texture bind) are places where we
see hangs.

BUG=580616
==========

[ccameron, 2016-08-12 21:44:58]

ccameron@chromium.org changed reviewers:
+ holte@chromium.org, zmo@chromium.org

[ccameron, 2016-08-12 21:45:40]

Description was changed from

==========
Mac: Loosen CoreAnimation blacklist on 10.10 and histograms to watch

This was only ever observed on this particular GPU.

Add histograms to watch glFlush and CATransaction time, since they
(in addition to IOSurface create and texture bind) are places where we
see hangs.

BUG=580616
==========

to

==========
Mac: Loosen CoreAnimation blacklist on 10.10 and histograms to watch

This was only ever observed on this particular GPU.

Add histograms to watch glFlush and CATransaction time, since they
(in addition to IOSurface create and texture bind) are places where we
see hangs.

BUG=580616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-08-12 21:46:47]

ccameron@chromium.org changed reviewers:
+ erikchen@chromium.org

[ccameron, 2016-08-12 21:46:47]

ptal

[erikchen, 2016-08-12 21:49:26]

https://codereview.chromium.org/2241003002/diff/20001/gpu/ipc/service/image_t...
File gpu/ipc/service/image_transport_surface_overlay_mac.mm (right):

https://codereview.chromium.org/2241003002/diff/20001/gpu/ipc/service/image_t...
gpu/ipc/service/image_transport_surface_overlay_mac.mm:235:
base::TimeTicks::Now() - start_time);
reuse after_flush_before_commit_time.

Also, did you mean to use before_flush_time instead of start_time?

[ccameron, 2016-08-12 23:48:41]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 23:49:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-08-13 00:13:00]

whoops -- fixed

[erikchen, 2016-08-13 00:13:43]

lgtm

[Steven Holte, 2016-08-13 00:41:47]

histograms lgtm

[commit-bot: I haz the power, 2016-08-13 00:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 00:54:36]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-08-15 17:48:27]

On 2016/08/13 00:41:47, Steven Holte wrote:
> histograms lgtm

lgtm

[ccameron, 2016-08-15 18:26:11]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-08-15 18:26:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 19:14:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-15 19:19:43]

Description was changed from

==========
Mac: Loosen CoreAnimation blacklist on 10.10 and histograms to watch

This was only ever observed on this particular GPU.

Add histograms to watch glFlush and CATransaction time, since they
(in addition to IOSurface create and texture bind) are places where we
see hangs.

BUG=580616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Mac: Loosen CoreAnimation blacklist on 10.10 and histograms to watch

This was only ever observed on this particular GPU.

Add histograms to watch glFlush and CATransaction time, since they
(in addition to IOSurface create and texture bind) are places where we
see hangs.

BUG=580616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b9bc972508ad89ce3a9c6b1045b725cd23646c5e
Cr-Commit-Position: refs/heads/master@{#412012}
==========

[commit-bot: I haz the power, 2016-08-15 19:19:44]

Patchset 3 (id:??) landed as
https://crrev.com/b9bc972508ad89ce3a9c6b1045b725cd23646c5e
Cr-Commit-Position: refs/heads/master@{#412012}