Move |ScopedWebInputEvent| and |WebInputEventTraits| from |content::| to "ui/events/blink"

Move |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to "ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits|
from |content::| to "ui/events/blink", so they can be accessed by
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only
need |WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each
file to grow.

After discussion with dtapuska@ and tdresser@ it doesn't really
matter whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it
later if it's actually causing problems.

BUG=637393
Committed: https://crrev.com/4a975194104af57c2c05f8dc0144e94a79dc2076
Cr-Commit-Position: refs/heads/master@{#412579}

[chongz, 2016-08-12 22:00:47]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 22:01:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 22:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 22:20:55]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[chongz, 2016-08-15 00:14:25]

Description was changed from

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| to |ui::|

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to |ui::|, so they can be accessed by |InputHandlerProxy|.

BUG=637393
==========

to

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| to |ui::|

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to |ui::|, so they can be accessed by |InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

BUG=637393
==========

[chongz, 2016-08-15 00:15:30]

Description was changed from

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| to |ui::|

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to |ui::|, so they can be accessed by |InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

BUG=637393
==========

to

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from |content::| to |ui::|

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to |ui::|, so they can be accessed by |InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

BUG=637393
==========

[chongz, 2016-08-15 18:45:14]

chongz@chromium.org changed reviewers:
+ dtapuska@chromium.org

[chongz, 2016-08-15 18:45:15]

dtapuska@ please also take a look at this CL as well. I'm not sure if I should
move both |ScopedWebInputEvent| and |WebInputEventTraits|? Thanks!

[chongz, 2016-08-16 14:43:21]

Description was changed from

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from |content::| to |ui::|

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to |ui::|, so they can be accessed by |InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

BUG=637393
==========

to

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from |content::| to |ui::|

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to |ui::|, so they can be accessed by |InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only need
|WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each file to
grow.

After discussion with dtapuska@ and tdresser@ it really doesn't matter
whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it later if it
is actually cause problems.

BUG=637393
==========

[chongz, 2016-08-16 14:44:57]

Description was changed from

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from |content::| to |ui::|

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to |ui::|, so they can be accessed by |InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only need
|WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each file to
grow.

After discussion with dtapuska@ and tdresser@ it really doesn't matter
whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it later if it
is actually cause problems.

BUG=637393
==========

to

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from |content::| to
"ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to "ui/events/blink", so they can be accessed by 
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only need 
|WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each file 
to grow.

After discussion with dtapuska@ and tdresser@ it really doesn't matter
whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it later if 
it's actually cause problems.

BUG=637393
==========

[chongz, 2016-08-16 14:45:51]

Description was changed from

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from |content::| to
"ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to "ui/events/blink", so they can be accessed by 
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only need 
|WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each file 
to grow.

After discussion with dtapuska@ and tdresser@ it really doesn't matter
whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it later if 
it's actually cause problems.

BUG=637393
==========

to

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from 
|content::| to "ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| 
from |content::| to "ui/events/blink", so they can be accessed by 
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only 
need |WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each 
file to grow.

After discussion with dtapuska@ and tdresser@ it doesn't really
matter whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it
later if it's actually cause problems.

BUG=637393
==========

[chongz, 2016-08-16 14:46:25]

Description was changed from

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from 
|content::| to "ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| 
from |content::| to "ui/events/blink", so they can be accessed by 
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only 
need |WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each 
file to grow.

After discussion with dtapuska@ and tdresser@ it doesn't really
matter whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it
later if it's actually cause problems.

BUG=637393
==========

to

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from 
|content::| to "ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| 
from |content::| to "ui/events/blink", so they can be accessed by 
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only 
need |WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each 
file to grow.

After discussion with dtapuska@ and tdresser@ it doesn't really
matter whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it
later if it's actually causing problems.

BUG=637393
==========

[chongz, 2016-08-16 14:47:01]

dtapuska@ I've updated CL description as per our discussion, PTAL, thanks!

[dtapuska, 2016-08-16 14:50:44]

On 2016/08/16 14:47:01, chongz wrote:
> dtapuska@ I've updated CL description as per our discussion, PTAL, thanks!

lgtm

[chongz, 2016-08-16 19:05:38]

chongz@chromium.org changed reviewers:
+ avi@chromium.org

[chongz, 2016-08-16 19:05:39]

avi@ PTAL at this CL, thanks!

[Avi (use Gerrit), 2016-08-16 19:48:25]

avi@chromium.org changed reviewers:
+ nick@chromium.org

[Avi (use Gerrit), 2016-08-16 19:48:26]

lgtm

This looks reasonable to me. Nick, can you give me a second set of eyes?

[ncarter (slow), 2016-08-16 21:09:04]

i have no objections

https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
File ui/events/blink/web_input_event_traits.cc (right):

https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
ui/events/blink/web_input_event_traits.cc:1: // Copyright 2013 The Chromium
Authors. All rights reserved.
2016

https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
ui/events/blink/web_input_event_traits.cc:23: void ApppendEventDetails(const
WebKeyboardEvent& event, std::string* result) {
ppp?

https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
File ui/events/blink/web_input_event_traits.h (right):

https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
ui/events/blink/web_input_event_traits.h:1: // Copyright 2013 The Chromium
Authors. All rights reserved.
2016

[dtapuska, 2016-08-17 14:49:52]

dtapuska@chromium.org changed reviewers:
+ kenrb@chromium.org

[dtapuska, 2016-08-17 14:50:36]

On 2016/08/16 21:09:04, ncarter (ooo) wrote:
> i have no objections
> 
>
https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
> File ui/events/blink/web_input_event_traits.cc (right):
> 
>
https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
> ui/events/blink/web_input_event_traits.cc:1: // Copyright 2013 The Chromium
> Authors. All rights reserved.
> 2016
> 
>
https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
> ui/events/blink/web_input_event_traits.cc:23: void ApppendEventDetails(const
> WebKeyboardEvent& event, std::string* result) {
> ppp?
> 
>
https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
> File ui/events/blink/web_input_event_traits.h (right):
> 
>
https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
> ui/events/blink/web_input_event_traits.h:1: // Copyright 2013 The Chromium
> Authors. All rights reserved.
> 2016

kenrb@ can you stamp the ipc trait changes?

[kenrb, 2016-08-17 15:20:45]

ipc lgtm

[chongz, 2016-08-17 16:34:19]

Synced with sahel@ about cl/2250233002, I will land first since I've already got
LGTMs.

https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
File ui/events/blink/web_input_event_traits.cc (right):

https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
ui/events/blink/web_input_event_traits.cc:1: // Copyright 2013 The Chromium
Authors. All rights reserved.
On 2016/08/16 21:09:04, ncarter (ooo) wrote:
> 2016

Done.

https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
ui/events/blink/web_input_event_traits.cc:23: void ApppendEventDetails(const
WebKeyboardEvent& event, std::string* result) {
On 2016/08/16 21:09:04, ncarter (ooo) wrote:
> ppp?

I'm not sure what does 'ppp' mean?

https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
File ui/events/blink/web_input_event_traits.h (right):

https://codereview.chromium.org/2240983003/diff/1/ui/events/blink/web_input_e...
ui/events/blink/web_input_event_traits.h:1: // Copyright 2013 The Chromium
Authors. All rights reserved.
On 2016/08/16 21:09:04, ncarter (ooo) wrote:
> 2016

Done.

[chongz, 2016-08-17 16:47:51]

The CQ bit was checked by chongz@chromium.org

[chongz, 2016-08-17 16:47:51]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
avi@chromium.org, dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2240983003/#ps20001
(title: "Rebase and ncarter's review")

[commit-bot: I haz the power, 2016-08-17 16:48:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 17:50:02]

Description was changed from

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from 
|content::| to "ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| 
from |content::| to "ui/events/blink", so they can be accessed by 
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only 
need |WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each 
file to grow.

After discussion with dtapuska@ and tdresser@ it doesn't really
matter whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it
later if it's actually causing problems.

BUG=637393
==========

to

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from 
|content::| to "ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| 
from |content::| to "ui/events/blink", so they can be accessed by 
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only 
need |WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each 
file to grow.

After discussion with dtapuska@ and tdresser@ it doesn't really
matter whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it
later if it's actually causing problems.

BUG=637393
==========

[commit-bot: I haz the power, 2016-08-17 17:50:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 17:55:20]

Description was changed from

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from 
|content::| to "ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits| 
from |content::| to "ui/events/blink", so they can be accessed by 
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only 
need |WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each 
file to grow.

After discussion with dtapuska@ and tdresser@ it doesn't really
matter whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it
later if it's actually causing problems.

BUG=637393
==========

to

==========
Move |ScopedWebInputEvent| and |WebInputEventTraits| from
|content::| to "ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits|
from |content::| to "ui/events/blink", so they can be accessed by
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only
need |WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each
file to grow.

After discussion with dtapuska@ and tdresser@ it doesn't really
matter whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it
later if it's actually causing problems.

BUG=637393

Committed: https://crrev.com/4a975194104af57c2c05f8dc0144e94a79dc2076
Cr-Commit-Position: refs/heads/master@{#412579}
==========

[commit-bot: I haz the power, 2016-08-17 17:55:22]

Patchset 2 (id:??) landed as
https://crrev.com/4a975194104af57c2c05f8dc0144e94a79dc2076
Cr-Commit-Position: refs/heads/master@{#412579}