Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Side by Side Diff: content/common/input/touch_event_stream_validator.cc

Issue 2240983003: Move |ScopedWebInputEvent| and |WebInputEventTraits| from |content::| to "ui/events/blink" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and ncarter's review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/input/touch_event_stream_validator.h" 5 #include "content/common/input/touch_event_stream_validator.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "content/common/input/web_input_event_traits.h"
10 #include "content/common/input/web_touch_event_traits.h" 9 #include "content/common/input/web_touch_event_traits.h"
10 #include "ui/events/blink/web_input_event_traits.h"
11 11
12 using base::StringPrintf; 12 using base::StringPrintf;
13 using blink::WebInputEvent; 13 using blink::WebInputEvent;
14 using blink::WebTouchEvent; 14 using blink::WebTouchEvent;
15 using blink::WebTouchPoint; 15 using blink::WebTouchPoint;
16 16
17 namespace content { 17 namespace content {
18 namespace { 18 namespace {
19 19
20 const WebTouchPoint* FindTouchPoint(const WebTouchEvent& event, int id) { 20 const WebTouchPoint* FindTouchPoint(const WebTouchEvent& event, int id) {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 54
55 WebTouchEvent previous_event = previous_event_; 55 WebTouchEvent previous_event = previous_event_;
56 previous_event_ = event; 56 previous_event_ = event;
57 57
58 if (!event.touchesLength) { 58 if (!event.touchesLength) {
59 error_msg->append("Touch event is empty.\n"); 59 error_msg->append("Touch event is empty.\n");
60 return false; 60 return false;
61 } 61 }
62 62
63 if (!WebInputEvent::isTouchEventType(event.type)) { 63 if (!WebInputEvent::isTouchEventType(event.type)) {
64 error_msg->append(StringPrintf("Touch event has invalid type: %s\n", 64 error_msg->append(
65 WebInputEventTraits::GetName(event.type))); 65 StringPrintf("Touch event has invalid type: %s\n",
66 ui::WebInputEventTraits::GetName(event.type)));
66 } 67 }
67 68
68 // Allow "hard" restarting of touch stream validation. This is necessary 69 // Allow "hard" restarting of touch stream validation. This is necessary
69 // in cases where touch event forwarding ceases in response to the event ack 70 // in cases where touch event forwarding ceases in response to the event ack
70 // or removal of touch handlers. 71 // or removal of touch handlers.
71 if (WebTouchEventTraits::IsTouchSequenceStart(event)) 72 if (WebTouchEventTraits::IsTouchSequenceStart(event))
72 previous_event = WebTouchEvent(); 73 previous_event = WebTouchEvent();
73 74
74 // Unreleased points from the previous event should exist in the latest event. 75 // Unreleased points from the previous event should exist in the latest event.
75 for (unsigned i = 0; i < previous_event.touchesLength; ++i) { 76 for (unsigned i = 0; i < previous_event.touchesLength; ++i) {
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 } else { 154 } else {
154 found_valid_state_for_type = true; 155 found_valid_state_for_type = true;
155 } 156 }
156 break; 157 break;
157 } 158 }
158 } 159 }
159 160
160 if (!found_valid_state_for_type) { 161 if (!found_valid_state_for_type) {
161 error_msg->append( 162 error_msg->append(
162 StringPrintf("No valid touch point corresponding to event type: %s\n", 163 StringPrintf("No valid touch point corresponding to event type: %s\n",
163 WebInputEventTraits::GetName(event.type))); 164 ui::WebInputEventTraits::GetName(event.type)));
164 } 165 }
165 166
166 return error_msg->empty(); 167 return error_msg->empty();
167 } 168 }
168 169
169 } // namespace content 170 } // namespace content
OLDNEW
« no previous file with comments | « content/common/input/scoped_web_input_event.cc ('k') | content/common/input/web_input_event_traits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698