Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2240803003: [ARM64] Change TruncateInt64ToInt32 to a NOP. (Closed)

Created:
4 years, 4 months ago by georgia.kouveli
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM64] Change TruncateInt64ToInt32 to a NOP. BUG= Committed: https://crrev.com/227353b76af72b7e3b8667c3ca80021fcdfe611c Cr-Commit-Position: refs/heads/master@{#38612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +3 lines, -12 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
georgia.kouveli
As far as I can tell, 32-bit operations don't rely on the top 32-bits in ...
4 years, 4 months ago (2016-08-12 10:21:45 UTC) #2
epertoso
lgtm
4 years, 4 months ago (2016-08-12 10:55:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240803003/1
4 years, 4 months ago (2016-08-12 10:56:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 11:29:56 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 11:30:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/227353b76af72b7e3b8667c3ca80021fcdfe611c
Cr-Commit-Position: refs/heads/master@{#38612}

Powered by Google App Engine
This is Rietveld 408576698