chrome/test/data/bookmark_html_reader/firefox3.html - Issue 22408007: Remove "<HR>" tags to import Firefox bookmarks correctly.

Unified Diff: chrome/test/data/bookmark_html_reader/firefox3.html

Issue 22408007: Remove "<HR>" tags to import Firefox bookmarks correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits fix and add a test case. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/bookmark_html_reader/firefox3.html

diff --git a/chrome/test/data/bookmark_html_reader/firefox3.html b/chrome/test/data/bookmark_html_reader/firefox3.html

new file mode 100644

index 0000000000000000000000000000000000000000..745fef05abda11a4051a1bce457d6dc54e34eae0

--- /dev/null

+++ b/chrome/test/data/bookmark_html_reader/firefox3.html

@@ -0,0 +1,23 @@

+<!DOCTYPE NETSCAPE-Bookmark-file-1>

+<!-- This is an automatically generated file.

+ It will be read and overwritten.

+ DO NOT EDIT! -->

+<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8">

+<TITLE>Bookmarks</TITLE>

+<H1>Bookmarks Menu</H1>

+<DL><p>

+ <DT><A HREF="place:folder=BOOKMARKS_MENU&folder=UNFILED_BOOKMARKS&folder=TOOLBAR&sort=12&excludeQueries=1&maxResults=10&queryType=1">Recently Bookmarked</A>

+ <DT><A HREF="place:sort=14&type=6&maxResults=10&queryType=1">Recent Tags</A>

+ <HR> <DT><A HREF="https://addons.mozilla.org/en-US/firefox/bookmarks/" ADD_DATE="1360718511" LAST_MODIFIED="1360718511">Get Bookmark Add-ons</A>

+ <HR> <DT><H3 ADD_DATE="1360718511" LAST_MODIFIED="1360718511">Internet</H3>

gab 2013/08/09 13:27:30 There is no matching </HR>? What is this format?!

zhchbin 2013/08/09 14:20:00 In HTML, the <hr> tag has no end tag.

gab 2013/08/09 14:29:03 Ah ok, thanks, sorry HTML noob here :).

+ <DL><p>

+ <DT><A HREF="http://www.google.com.au/" ADD_DATE="1360718511" LAST_MODIFIED="1360718511">Google</A>

+ <DT><A HREF="http://youtube.com" ADD_DATE="1360718511" LAST_MODIFIED="1360718511">YouTube</A>

+ </DL><p>

+ <DT><H3 ADD_DATE="1360718511" LAST_MODIFIED="1371433539">BIRDS</H3>

+ <DL><p>

+ <DT><A HREF="http://www.birds.com" ADD_DATE="1360718511" LAST_MODIFIED="1360718511">Birds</A>

+ <DT><A HREF="http://www.flickr.com" ADD_DATE="1360718511" LAST_MODIFIED="1360718511">Flickr</A>

+ </DL><p>

+</DL><p>

« no previous file with comments | « no previous file | chrome/utility/importer/bookmark_html_reader.cc » ('j') | chrome/utility/importer/bookmark_html_reader.cc » ('J')