chrome/test/data/bookmark_html_reader/firefox3.html - Issue 22408007: Remove "<HR>" tags to import Firefox bookmarks correctly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/bookmark_html_reader/firefox3.html

Issue 22408007: Remove "<HR>" tags to import Firefox bookmarks correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits fix and add a test case. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE NETSCAPE-Bookmark-file-1>

	2 <!-- This is an automatically generated file.

	3 It will be read and overwritten.

	4 DO NOT EDIT! -->

	5 <META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8">

	6 <TITLE>Bookmarks</TITLE>

	7 <H1>Bookmarks Menu</H1>

	8

	9 <DL><p>

	10 <DT><A HREF="place:folder=BOOKMARKS_MENU&folder=UNFILED_BOOKMARKS&folder=TOO LBAR&sort=12&excludeQueries=1&maxResults=10&queryType=1">Recently Bookmarked</A>

	11 <DT><A HREF="place:sort=14&type=6&maxResults=10&queryType=1">Recent Tags</A>

	12 <HR> <DT><A HREF="https://addons.mozilla.org/en-US/firefox/bookmarks/" AD D_DATE="1360718511" LAST_MODIFIED="1360718511">Get Bookmark Add-ons</A>

	13 <HR> <DT><H3 ADD_DATE="1360718511" LAST_MODIFIED="1360718511">Internet</H 3>
	gab 2013/08/09 13:27:30 There is no matching </HR>? What is this format?! There is no matching </HR>? What is this format?! Does this file come straight from FF? If so, is it really from FF3?! If not, we should probably name the file accordingly. zhchbin 2013/08/09 14:20:00 In HTML, the <hr> tag has no end tag. Show quoted text On 2013/08/09 13:27:30, gab wrote: > There is no matching </HR>? What is this format?! In HTML, the <hr> tag has no end tag. Show quoted text > > Does this file come straight from FF? > > If so, is it really from FF3?! If not, we should probably name the file > accordingly. Oops, I thought the "2" in "firefox2.html" is a magic number, so I just follow the way.... This file is exported from Firefox. gab 2013/08/09 14:29:03 Ah ok, thanks, sorry HTML noob here :). Show quoted text On 2013/08/09 14:20:00, zhchbin wrote: > On 2013/08/09 13:27:30, gab wrote: > > There is no matching </HR>? What is this format?! > > In HTML, the <hr> tag has no end tag. Ah ok, thanks, sorry HTML noob here :). Show quoted text > > > > > Does this file come straight from FF? > > > > If so, is it really from FF3?! If not, we should probably name the file > > accordingly. > > Oops, I thought the "2" in "firefox2.html" is a magic number, so I just follow > the way.... > > This file is exported from Firefox. Ok sg, please rename file accordingly.
	14 <DL><p>

	15 <DT><A HREF="http://www.google.com.au/" ADD_DATE="1360718511" LAST_MODIF IED="1360718511">Google</A>

	16 <DT><A HREF="http://youtube.com" ADD_DATE="1360718511" LAST_MODIFIED="13 60718511">YouTube</A>

	17 </DL><p>

	18 <DT><H3 ADD_DATE="1360718511" LAST_MODIFIED="1371433539">BIRDS</H3>

	19 <DL><p>

	20 <DT><A HREF="http://www.birds.com" ADD_DATE="1360718511" LAST_MODIFIED=" 1360718511">Birds</A>

	21 <DT><A HREF="http://www.flickr.com" ADD_DATE="1360718511" LAST_MODIFIED= "1360718511">Flickr</A>

	22 </DL><p>

	23 </DL><p>

OLD	NEW

« no previous file with comments | « no previous file | chrome/utility/importer/bookmark_html_reader.cc » ('j') | chrome/utility/importer/bookmark_html_reader.cc » ('J')