Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2240723002: Fix an integer overflow in CStretchEngine constructor (Closed)

Created:
4 years, 4 months ago by Wei Li
Modified:
4 years, 4 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix an integer overflow in CStretchEngine constructor When the source bitmap's width and height are large, the multiplication could easily overflow a signed integer. Change to use 'long long' type for calculation to avoid that. BUG=chromium:635663 Committed: https://pdfium.googlesource.com/pdfium/+/229d05df5bc5deb3890b26b614113c25d9b6935e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/dib/fx_dib_engine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A core/fxge/dib/fx_dib_engine_unittest.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Wei Li
pls review, thanks
4 years, 4 months ago (2016-08-11 23:36:15 UTC) #6
dsinclair
lgtm
4 years, 4 months ago (2016-08-12 02:43:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240723002/1
4 years, 4 months ago (2016-08-12 02:43:42 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 02:44:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/229d05df5bc5deb3890b26b614113c25d9b6...

Powered by Google App Engine
This is Rietveld 408576698