core/fxge/dib/fx_dib_engine.cpp - Issue 2240723002: Fix an integer overflow in CStretchEngine constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/dib/fx_dib_engine.cpp

Issue 2240723002: Fix an integer overflow in CStretchEngine constructor (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/dib/fx_dib_engine.cpp

diff --git a/core/fxge/dib/fx_dib_engine.cpp b/core/fxge/dib/fx_dib_engine.cpp

index 520148fc7735d75ab2adcf5c147c72e0ef23133f..88b0d4b271632ce2b7f6aac696e68c34cf6d2ae0 100644

--- a/core/fxge/dib/fx_dib_engine.cpp

+++ b/core/fxge/dib/fx_dib_engine.cpp

@@ -306,8 +306,8 @@ CStretchEngine::CStretchEngine(IFX_ScanlineComposer* pDestBitmap,

FX_BOOL bInterpol =

flags & FXDIB_INTERPOL || flags & FXDIB_BICUBIC_INTERPOL;

if (!bInterpol && FXSYS_abs(dest_width) != 0 &&

- FXSYS_abs(dest_height) <

- m_SrcWidth * m_SrcHeight * 8 / FXSYS_abs(dest_width)) {

+ FXSYS_abs(dest_height) / 8 < static_cast<long long>(m_SrcWidth) *

+ m_SrcHeight / FXSYS_abs(dest_width)) {

flags = FXDIB_INTERPOL;

}

m_Flags = flags;

« no previous file with comments | « BUILD.gn ('k') | core/fxge/dib/fx_dib_engine_unittest.cpp » ('j') | no next file with comments »