Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2240713003: Revert of Fix 4444 on Vulkan devices who don't support RGBA_4444 (Closed)

Created:
4 years, 4 months ago by egdaniel
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix 4444 on Vulkan devices who don't support RGBA_4444 (patchset #4 id:60001 of https://codereview.chromium.org/2238563002/ ) Reason for revert: test failing on some gpus Original issue's description: > Fix 4444 on Vulkan devices who don't support RGBA_4444 > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002 > > Committed: https://skia.googlesource.com/skia/+/637b3bf2b9c10398d823bd015a722842d4f2f971 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a825d5317c87784fa4ee7ff8e51ec3c2a9e0d2e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -82 lines) Patch
M src/gpu/vk/GrVkCaps.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkCaps.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M src/gpu/vk/GrVkUtil.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
D tests/PackedConfigsTextureTest.cpp View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
egdaniel
Created Revert of Fix 4444 on Vulkan devices who don't support RGBA_4444
4 years, 4 months ago (2016-08-11 23:17:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240713003/1
4 years, 4 months ago (2016-08-11 23:17:34 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 23:17:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a825d5317c87784fa4ee7ff8e51ec3c2a9e0d2e3

Powered by Google App Engine
This is Rietveld 408576698