Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: third_party/WebKit/Source/platform/BUILD.gn

Issue 2240663003: [DevTools] Introduce config file for inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2226863003
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/BUILD.gn
diff --git a/third_party/WebKit/Source/platform/BUILD.gn b/third_party/WebKit/Source/platform/BUILD.gn
index ffa75b77b5736d9e946c7d6c6c1a9a6ff0c02fb7..a356cce8ee27409a83df7e04cc88115775713fb4 100644
--- a/third_party/WebKit/Source/platform/BUILD.gn
+++ b/third_party/WebKit/Source/platform/BUILD.gn
@@ -203,6 +203,7 @@ action("inspector_protocol_sources") {
]
inputs = [
"v8_inspector/js_protocol.json",
+ "v8_inspector/inspector_protocol_config.json",
]
outputs = [
"$blink_platform_output_dir/v8_inspector/protocol/Console.cpp",
@@ -220,22 +221,10 @@ action("inspector_protocol_sources") {
]
args = [
- "--protocol",
- rebase_path("v8_inspector/js_protocol.json", root_build_dir),
- "--string_type",
- "String16",
- "--export_macro",
- "PLATFORM_EXPORT",
- "--output_dir",
- rebase_path(blink_platform_output_dir + "/v8_inspector/protocol",
- root_build_dir),
- "--output_package",
- "platform/v8_inspector/protocol",
- "--exported_dir",
- rebase_path(blink_platform_output_dir + "/v8_inspector/public/protocol",
- root_build_dir),
- "--exported_package",
- "platform/v8_inspector/public/protocol",
+ "--output_base",
+ rebase_path(blink_platform_output_dir, root_build_dir),
+ "--config",
+ rebase_path("v8_inspector/inspector_protocol_config.json", root_build_dir),
]
}

Powered by Google App Engine
This is Rietveld 408576698