Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2240483002: Turning optimizations on for the bulk of webview (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turning optimizations on for the bulk of webview This shaves 85kb from the .dex size and 10kb from memory overhead. BUG=627139 Committed: https://crrev.com/0e0838f9baa10ec6382faf06ba37b6e1a6f80d6c Cr-Commit-Position: refs/heads/master@{#412329}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M android_webview/apk/java/proguard.flags View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
smaier
4 years, 4 months ago (2016-08-11 15:32:36 UTC) #4
Torne
LGTM; if we see too many confusing java stack traces we can revisit.
4 years, 4 months ago (2016-08-16 14:51:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240483002/1
4 years, 4 months ago (2016-08-16 18:46:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/252124)
4 years, 4 months ago (2016-08-16 18:49:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240483002/20001
4 years, 4 months ago (2016-08-16 19:53:10 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 20:36:18 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 20:38:13 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e0838f9baa10ec6382faf06ba37b6e1a6f80d6c
Cr-Commit-Position: refs/heads/master@{#412329}

Powered by Google App Engine
This is Rietveld 408576698