Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: android_webview/apk/java/proguard.flags

Issue 2240483002: Turning optimizations on for the bulk of webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/apk/java/proguard.flags
diff --git a/android_webview/apk/java/proguard.flags b/android_webview/apk/java/proguard.flags
index c94cca6949170eb92d63f2a1cc980610f42cbeb0..0c44d0332ed2c7ba9fc4d04d1fbfc1d0ef96af17 100644
--- a/android_webview/apk/java/proguard.flags
+++ b/android_webview/apk/java/proguard.flags
@@ -1,7 +1,10 @@
# Don't rename anything, it makes stack traces unintelligible. We only allow the
# obfuscation pass to run so that we can discard attributes like local variable
-# tables.
--keepnames class *** { *; }
+# tables. However, we don't want to lose out on optimizations, so although they
+# can occasionally make the stack trace a bit stranger with inlining, it won't
+# make a big difference for the users seeing the stacktraces. We can always use
+# build/android/stacktrace/java_deobfuscate.py to fix the stacktrace up for us.
+-keepnames,allowoptimization class *** { *; }
# The following chart was created on Aug. 11, 2016, to decide on 3 optimization
# passes.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698